Tax values are calculated wrong when adding products

[marksu]

Some reason zen_get_tax_rate() calculates the tax wrong.
It return 44 and not 22 on my products. It sums the two Tax Rate values (22%). What am I doing wrong?

Example when adding a product.
Tax Class: Taxable Goods
Then when typing Products Price (Gross) value it auto calculates Products Price (Net) value using 44% tax and not 22%.



HERE ARE MY TAX SETTINGS

Zone Definitions
1 Folder EEC VAT Zone European economic community for VAT [EU countries]
2 Folder Finland Home country

Tax Classes
1 Taxable Goods

Tax Rates
1 Taxable Goods EEC VAT Zone 22%
2 Taxable Goods Finland 22%

[marksu]

Then function zen_get_tax_rate(...) lookes like below.
It is in ...admin\includes\functions\general.php file.

I do not understand why function sum the tax rates?
I could edit the function but not sure if it effect other code. I would presume there is a reason for the sum calculation.


...

$tax = $db->Execute("select SUM(tax_rate) as tax_rate
from (" . TABLE_TAX_RATES . " tr
left join " . TABLE_ZONES_TO_GEO_ZONES . " za
ON tr.tax_zone_id = za.geo_zone_id
left join " . TABLE_GEO_ZONES . " tz ON tz.geo_zone_id = tr.tax_zone_id )
WHERE (za.zone_country_id IS NULL
OR za.zone_country_id = 0
OR za.zone_country_id = '" . (int)$country_id . "')
AND (za.zone_id IS NULL OR za.zone_id = 0
OR za.zone_id = '" . (int)$zone_id . "')
AND tr.tax_class_id = '" . (int)$class_id . "'
GROUP BY tr.tax_priority");

if ($tax->RecordCount() > 0) {
$tax_multiplier = 0;
while (!$tax->EOF) {
$tax_multiplier += $tax->fields['tax_rate'];
$tax->MoveNext();
}
return $tax_multiplier;
} else {
return 0;
}

[marksu]

The example above to add new product seems to use other function not function zen_get_tax_rate(...) cause when I changed the function it still gave that same problem.

Seems as a other module uses function zen_get_tax_rate(...) which also give false result. So maybe my settings are false?

[DrByte]

Some reason zen_get_tax_rate() calculates the tax wrong.
It return 44 and not 22 on my products. It sums the two Tax Rate values (22%). What am I doing wrong?

If you're referring to the Product Price Gross and Product Price Net fields in the admin when adding/editing a product, there's a known display bug in Zen Cart versions older than v1.3.8 that causes the values to show on-screen incorrectly.

However, the bug is only on display in the admin. The correct calculation occurs on the shopping-cart side. Customers are charged the correct amount.

Upgrading to v1.3.8 should solve the problem. Or, you could search the forum and find the posted solution for v1.3.7 a couple years ago.

[marksu]

If you're referring to the Product Price Gross and Product Price Net fields in the admin when adding/editing a product, there's a known display bug in Zen Cart versions older than v1.3.8 that causes the values to show on-screen incorrectly.

However, the bug is only on display in the admin. The correct calculation occurs on the shopping-cart side. Customers are charged the correct amount.

Upgrading to v1.3.8 should solve the problem. Or, you could search the forum and find the posted solution for v1.3.7 a couple years ago.

Thank you for replying.
Still my big question is that why zen_get_tax_rate(...) function is summing my tax values and giving false result. I have edited it so it does not do that anymore . Still wonder why it calculates that way. I would presume there is a reason for that.

I am afraid that by editing the core function zen_get_tax_rate(...) some other problems could accure?

[DrByte]

I believe zen_get_tax_rate was adjusted in 1.3.8 to specifically address that problem.

[marksu]

I believe zen_get_tax_rate was adjusted in 1.3.8 to specifically address that problem.

OK maybe I shoudl dload that wercion and check the function.
Thanks for the tip.