Loading a javascript site-wide

[ckosloff]

Depends on the script you are using, for example if you are using a js framework such as jquery or mootools you dont need to insert the code to onload at all. For jquery, you can use $(document).ready(){//code here}

Hey yellow,
Obviously, you are super multi-tasking.
Actually, this is simpler than that.
I want to update the mod. for installing a Comodo Corner of Trust.
So far, this has been done by hacking into the files.
You can see the solutions that have been implemented by clicking on the link that misty provided.
That solution is incorrect and doesn't follow the guidelines for javascript in Zen Cart.
You should be able to load these scripts dynamically and unobtrusively, i.e. without modifying core Zen cart files at all.
I have achieved this for the header part, by loading the following in includes/templates/CUSTOM/jscript/jscript_comodocorner.js
//<![CDATA[
var cot_loc0=(window.ocation.protocol == "https:")? https://secure.comodo.net/trustlogo/javascript/cot.js" :
"http://www.trustlogo.com/trustlogo/javascript/cot.js";
document.writeln('<scr' + 'ipt language="JavaScript" src="'+cot_loc0+'" type="text\/javascript">' + '<\/scr' + 'ipt>');
//]]>
that's how I got rid of the hack to html_header.php.
Please note that I used the Zen Cart convention: there are no <script> tags, Zen Cart will put them in for you.
Also, the file has to be named in a certain way: jscript_XXX.js
Now, I am looking for help on the body part.
I know that within same jscript folder I have to create another on_load folder and put in there a file named on_load_comodocorner.js
This file has to have an on_load function (which can be called anything you like, of course).
This is what this function needs to load:
<a href="http://www.instantssl.com" id="comodoTL">SSL</a>
<script language="JavaScript" type="text/javascript">
COT("images/cornertrust.gif", "SC2", "none");
</script>
So here are my questions:
1) Should I leave off the <script> tags?
2) How do I load the anchor tag?
A suggestion on how to write the function would be much appreciated.
Thanks for the great support.

[ckosloff]

var cot_loc0=(window.location.protocol...
Typo in previous post, sorry.

[yellow1912]

For the <a>, I believe you have to put in in your code, just some where in your template code.
Or you can write a piece of code that append that to an element on your page '<a href="http://www.instantssl.com" id="comodoTL">SSL</a>'

I would go for the 1st choice since it's easier

For the second part, I never tried the body_onload but I dont think you need to put the script tag there if the file is .js. You only have to put the script tag if the file is .php (you can put .php files in the jscript folder)

[ckosloff]

For the <a>, I believe you have to put in in your code, just some where in your template code.
Or you can write a piece of code that append that to an element on your page '<a href="http://www.instantssl.com" id="comodoTL">SSL</a>'
I would go for the 1st choice since it's easier
For the second part, I never tried the body_onload but I dont think you need to put the script tag there if the file is .js. You only have to put the script tag if the file is .php (you can put .php files in the jscript folder)

Hey yellow,
Thanks indeed for quick answer.
Don't want to pester you very much.
Just a couple q.:
I know it would be easier to just hack the files as has been done so far, I did it myself and it works, but it doesn't look good and makes upgrades more difficult.
The whole point is to leave them files alone.
-------------------------------------
Or you can write a piece of code that append that to an element on your page '<a href="http://www.instantssl.com" id="comodoTL">SSL</a>'
-------------------------------------
How would I append that anchor tag?
What would be the syntax?
I cannot use document.write()...
Regarding the second issue, will try it both ways.
Probably you are right and no script tags are needed.
It's testing time!

[yellow1912]

When you edit the template file, it is not considered hacking in the code (obviously you do have to edit those files to change your template anyway).

The reason why I did not give the specific code because such code can have unexpected behavior on different browsers, so I usually do it using jquery or some other frameworks (which take care of the compatibility issue for me)

Also, after looking closely at your code, you may not even have to put it in the body onload, you can put that whole thing at the bottom of your page as well.

<a href="http://www.instantssl.com" id="comodoTL">SSL</a>
<script language="JavaScript" type="text/javascript">
COT("images/cornertrust.gif", "SC2", "none");
</script>

Some may argue that it's not good to do so, but if you have GoogleAnalytics or AdSense on your page you do the same thing anyway.

[ckosloff]

Yes, yes, that's the way it's been working.
And, yes, you do have to modify template files, that's not hacking.
It's just the javascripts that can be loaded dynamically, the wiki explains that in detail.
It can be done site-wide (header and body), and even page per page.
You may object that there is no need to fix something that works.
I kinda agree, it's just a "good practice" issue, recommended by DrByte.
Oh well, I'll have to review my javascript books and do some more research.
I do appreciate greatly your dedication.
Thank you so much and Happy Holidays!

[ckosloff]

Since I am not sure about the anchor, left it as is in the common tpl_main_page.php
The javascript I put in includes/templates/CUSTOM/jscript/on_load/on_load_comodocorner.js, without the script tags.
It didn't work.
However, it did work if I put it back in the template, with the script tags.
I am testing on a local demo site, without any other mods installed.
Any developer listening? DrByte?