Customer log in issue with SEO mod installed

[smatric]

[Initial info]
Version: Zen Cart v1.3.8a/v1.3.8
Changes: There were some code changes but unfortunately I know nothing about them
URL: https://amazingdiscoveries.org/store
[/Initial info]

Hi,

I have a problem with customer logging in. (Our store uses SSL ) Here is what to reproduce problem:

1) Restart web browser (probably cookies or other data need to be shreded)
2) Enter https://amazingdiscoveries.org/store
3) Fill in the log in form:

<form method="post" action="https://amazingdiscoveries.org/store/index.php?main_page=login&action=process&zenid=b231ce7a01753cc8bbcf6e0da29b1ccc" name="login"/>
Email: <input id="login-email-address" type="text" value="Email address ..." onfocus="this.value=(this.value=='Email address ...')? '' : this.value ;" onblur="if (this.value == '') this.value = 'Email address ...';" size="15" name="email_address"/>
Password: <input id="login-password" type="password" size="15" name="password"/>
<input type="hidden" value="8682c8e2d1459ff9da73c49dd17236ce" name="securityToken"/>
</form>

and click submit button.

4) A user will be directed back to the same place (will not be logged in). The only difference is that URL will change to f.ex.:
https://amazingdiscoveries.org/store...cf6e0da29b1ccc



When a user tries to log in again the same story repeats.

The way to log in is to first click on any product (f.ex. http://amazingdiscoveries.org/store/...41f67333720ca8) or to delete ?zenid=b231ce7a01753cc8bbcf6e0da29b1ccc (sample id) from URL and log in again.

Can you please help me to fix it. Or give me any suggestion which files should I look into for making changes.

[smatric]

Let me add one more thing. A webstore visitor cannot log in as long as all the links have zenid in get paramiters. As soon as zenid is cleared (in one of two ways describet in previous post) everything is as it should be.

I don't know if it changes enything but we use SEO for Zen Cart.

[DrByte]

It's almost certainly your so-called "SEO" addon causing your problems.

[smatric]

Thanks, you were right. After turning off Search Engine Optimization the problem is gone. Of course this is not a solution but now I know what is the cause of the problem.

[smatric]

Maybe someone will find it useful. The problem described above could be solved for our webstore by adding following three lines to includes/classes/seo.url.php to the end of SEO_URL class constructor:

if(!empty($this->attributes['SID']) && !empty($_COOKIE[zen_session_name()])) {
        $this->attributes['SID'] = '';
}

[DrByte]

Sounds like a dangerous edit to be making. Future readers are advised to use with caution.