ozpost shipping module

[robbie269]

There are several possible places where this can be 'fixed'

http://stackoverflow.com/questions/9...rds-in-php-5-4

Cheers
Rod

Great resource that stackoverflow site.
Did some more looking and found that to stop empty value errors you add = new stdClass(); . So I added $order = new stdClass(); above the troublesome line. It seems to have worked. Ran the shipping estimator again and there were no errors in the cache.

Do you think it is a safe option??

Robyn

[RodG]

Great resource that stackoverflow site.

Yeah, without even trying I find I seem to end up there when seeking the solution to many problems.

Did some more looking and found that to stop empty value errors you add = new stdClass(); . So I added $order = new stdClass(); above the troublesome line. It seems to have worked. Ran the shipping estimator again and there were no errors in the cache.

Well done. This is a far better solution than simply trying to suppress the warnings.

Do you think it is a safe option??

Personally I can't see it as being unsafe in any way, but I will add that this may not be the best place to initialize the $order variable (which is what you are doing). I'm making this statement because after having a quick look at the code/file I noted that the $order variable is being initialized on line#85 (albeit in a slightly different manner), and that if your fix is the 'correct' one, then the same fix should probably be applied to the other similar code within those elseif blocks.
IOW, you may have only achieved a partial fix for one possible condition.

The most important thing here though is that you have proven a point or two.

The 1st thing you've proven is that the fix works.
The second thing you have proven is that it isn't an ozpost problem, so I probably have no need to scour the ozpost code for a variable that I've failed to initialize.

So having found this, if Dr Byte, Ajeh, or one of the other dev team members could please take note. This same problem has been reported by another person in another thread in relation to the USP shipping module. In neither case is the problem in the shipping modules themselves, but as Robbie has found, it is being caused by an unitialised $order variable in the shipping_estimator.php file, which as you know is one of the core zencart files.

I'm expecting that there will be more and more of these error reports as the various hosts upgrade their PHP to V5.4.x so hopefully one of you guys can take a closer look into this to see if robbies solution is indeed 'safe', and whether or not there is an easier/better solution.

Cheers
Rod.

[RodG]

Do you think it is a safe option??

It still looks 'safe', but my earlier suspicions have just been confirmed, this is probably not the optimum location for the fix. You'll probably need to apply the same fix just before line#92

http://www.zen-cart.com/showthread.p...33#post1222033

Cheers
Rod

[robbie269]

It still looks 'safe', but my earlier suspicions have just been confirmed, this is probably not the optimum location for the fix. You'll probably need to apply the same fix just before line#92

http://www.zen-cart.com/showthread.p...33#post1222033

Cheers
Rod

Hi Rod

Funnily enough I did put it above line 92 as I was getting 2 errors, one at line 117 and one at line 92.
This is the code I added (red being the new code):

$order = new stdClass();
	$order->delivery = array('postcode' => $zip_code,

I may have to add the code above line 117 as well.

Robyn

[robbie269]

I may have to add the code above line 117 as well.

I got errors overnight for line 117 and 107 but not line 92. So I have partially fixed it.
I have now added the code above lines 92, 107 & 117. The lines with $order->delivery. Hopefully that gets rid of all the errors.

Robyn

[RodG]

I got errors overnight for line 117 and 107 but not line 92. So I have partially fixed it.
I have now added the code above lines 92, 107 & 117. The lines with $order->delivery. Hopefully that gets rid of all the errors.

I haven't tried, but I'm wondering if adding

$order = new stdClass();

To line#46 or thereabouts would take the place of all of the other additions (as well as any others not yet identified)

Cheers
Rod

[robbie269]

I haven't tried, but I'm wondering if adding

$order = new stdClass();

To line#46 or thereabouts would take the place of all of the other additions (as well as any others not yet identified)

Cheers
Rod

OK I have put it at line 46 only. Got no errors when I used the shipping estimator to test but I will see how it goes overnight.

Robyn

[robbie269]

No errors so far with code here:

 require_once('includes/classes/http_client.php'); // shipping in basket
//PHP5.4 fix
$order = new stdClass();
/*
// moved below and altered to include Tare
  // totals info
  $totalsDisplay = '';

Rod, I'll let you know if anything changes.

Robyn