Results 1 to 5 of 5
  1. #1
    Join Date
    Feb 2007
    Location
    South Florida, USA
    Posts
    1,374
    Plugin Contributions
    4

    Default [Not a bug] Missing double quotes in html_output.php

    File includes/functions/html_output.php
    has many occurrences of this:
    Code:
    $image .= ' title=" '
    I believe double quotes should be nested inside single quotes, therefore a double quote is missing.

  2. #2
    Join Date
    Jul 2005
    Location
    Upstate NY
    Posts
    22,010
    Plugin Contributions
    25

    Default Re: Missing double quotes in html_output.php

    That looks like code that is building an image call, and in the particular location a bit of HTML
    ( title=") is being accumulated into the variable. The next thing in the code should be to accumulate the value of a variable or constant with the title info, followed by another double quote " and probably a > to close the <img> tag.

  3. #3
    Join Date
    Jan 2004
    Posts
    66,446
    Plugin Contributions
    81

    Default Re: Missing double quotes in html_output.php

    Not a bug.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  4. #4
    Join Date
    Feb 2007
    Location
    South Florida, USA
    Posts
    1,374
    Plugin Contributions
    4

    Default Re: Missing double quotes in html_output.php

    Thanks all for the tuition.

  5. #5
    Join Date
    Feb 2007
    Location
    South Florida, USA
    Posts
    1,374
    Plugin Contributions
    4

    Default Re: [Not a bug] Missing double quotes in html_output.php

    I missed to read the whole line, the "missing double quotes" are at the end of the line.
    Sorry about that.

 

 

Similar Threads

  1. Replies: 1
    Last Post: 19 Oct 2010, 12:18 AM
  2. Replies: 1
    Last Post: 2 May 2010, 03:07 PM
  3. Replies: 2
    Last Post: 5 Dec 2007, 04:28 PM
  4. Replies: 1
    Last Post: 12 Oct 2006, 11:15 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg