CSS Button won't work :(

[Asdesign]

Hi,

I have set up my store to use CSS buttons over images and there seems to be a problem with one of the buttons, it just won't replace from an image to CSS based button. Check the pic, it's the pink button.

Side note: I noticed a bug worth mentioning. If you ever defined new buttons that are saved as .jpg you have to go back to button_names.php and change .jpg to .gif. Otherwise CSS buttons won't work for those specific buttons.

Whoever can help with my problem I'll be glad!

[SCR]http://img32.imageshack.us/img32/7374/csserror.jpg[/SCR]

[Asdesign]

Nevermind, figured it out on my own. It was the template which had wrong button parameters. Set it up right and it works like a charm! :)

[lausianne]

Dear Asdesign,

sometimes it helps others when you describe in more detail how you fixed your problem even when it appeared trivial to you.
I had the same thing. One button was not displayed as text, but as an image.

Eventually, after a long search I found the error where I would not have expected it at all. There is a very strange condition in html_output.php, line 267 (in my version)

strlen($alt)<30

So: any text longer than 30 characters is displayed as an image. Why???
My text is longer. Condition removed, all works well.

Cheers,
Ralf.

[Asdesign]

sometimes it helps others when you describe in more detail how you fixed your problem even when it appeared trivial to you.

I actually kinda do that, maybe not on this post but on most of my posts I usually do.

Anyway, you seem to have run through a different problem than the one I had but nice to see you got it solved. If one ever searches a solution for such a problem he'll probably find it with ease!

[lausianne]

Hi,

thanks for your reply. Yes, you probably do. It's just a bit frustrating when you're looking for a solution, then find a post where someone says he solved it but not how. ... Maybe I've done it myself before.

Anyway, I just found out why this piece "strlen($alt)<30" was there. Dirty. There are a few buttons that have long descriptions and there is little space for a button, e.g. update cart. Good thing to have an image there even when they are turned off. So if the text is looong (>30) -> image. I call this "dirty", because it's hard coded. If it was a setting in the backend, I'd have found it earlier. Or better yet, control this with a button parameter, or a special character in the button text.

Now I solved it like this (html_output.php, line 268 ff - my version):

$forceImage = $image[0];
if ($forceImage == '*') $image = substr($image, 1, strlen($image)-1);
//echo $forceImage . '<br/> Image: ' . $image; 
if ((strtolower(IMAGE_USE_CSS_BUTTONS) == 'yes') && ($forceImage <> '*')) return zenCssButton($image, $alt, 'submit', $sec_class /*, $parameters = ''*/ );

And in icon_names.php:

define('ICON_IMAGE_UPDATE', '*button_update_cart.gif');

Better ideas welcome!

Cheers,
Ralf.

[paulm]

The CSS buttons add on solves it like this:

- No limit on text length

- Admin option to use image buttons if images are found on the server (Use CSS buttons only. Or use CSS buttons, but let button images override the CSS buttons.)

[lausianne]

Thanks, Paul, that's of course a cleaner solution.