[Duplicate] "Show Newsletter Checkbox" setting bug

[hedron]

When the "Show Newsletter Checkbox" setting is set to 0 the system automatically subscribes new customer to the newsletter.

At first I thought that customers were subscribing by going to the My Account link, which in my template includes the newsletter options link (see this thread)

However when I disabled that newsletter options link under My Account I saw that new customers were still getting subscribed to the newsletter anyhow.

When that setting is set to 0 it should stop subscribing new customers and it should disable this page: index.php?main_page=account_newsletters


Why is this important? To transfer subscribers from the ZC newsletter list to the custom newsletter list it would be nice if a store owner knew which customers subscribed on their own instead of automatically...

[DrByte]

This is a duplicate report of the one already discussed here: http://www.zen-cart.com/forum/showthread.php?t=131942

[hedron]

Thank you.

If I read it correctly, that post only discusses setting 1 and 2, not setting 0. Did the bug fix also take care of the problem with setting 0?

Thanks.

[DrByte]

It should. What happened when you made the change?

[hedron]

I didn't change any code yet. :)

Your code on that post:

  if (ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '2') {
    $newsletter = 0;
    if (isset($_POST['newsletter'])) {
      $newsletter = zen_db_prepare_input($_POST['newsletter']);
    }
  } 

Does not show the status 0. I do not have programming expertise, but maybe I could modify that code and include a snippet like this?

ACCOUNT_NEWSLETTER_STATUS == '0' ||


For my case this is really irrelevant at this point, since I am not using the ZC default newsletter any longer. But I just thought it might be useful for future users...

[hedron]

Dr Byte,

I tested this out.

In my case, this works only when you also add the '0' setting. So it was a new bug after all ;)

This is the code that works for me:

if (ACCOUNT_NEWSLETTER_STATUS == '0' || ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '2') {
  $newsletter = 0;
  if (isset($_POST['newsletter'])) {
    $newsletter = zen_db_prepare_input($_POST['newsletter']);
  }

This is the code you suggested:

  if (ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '2') {
    $newsletter = 0;
    if (isset($_POST['newsletter'])) {
      $newsletter = zen_db_prepare_input($_POST['newsletter']);
    }
  }

It was pure luck I think, but I guess I am starting to learn something here...

[DrByte]

Actually, no, what you've done is basically make the entire "if" statement moot. So, that's not the best solution, since it will cause one of the settings not to work properly.

The code I suggested is correct, but it's also helpful to change this line earlier in the file:

  $newsletter = (ACCOUNT_NEWSLETTER_STATUS == '1' ? false : true);

to:

  $newsletter = (ACCOUNT_NEWSLETTER_STATUS == '1' || ACCOUNT_NEWSLETTER_STATUS == '0' ? false : true);

I'll add this information to the existing bug report so that it's a more complete resolution to the existing matter.

Thanks for testing.

[hedron]

Glad I asked...

Thank you for the new solution. If it does not work I will post back. I will keep an eye on the counter.

[hedron]

Actually, it works fine. I just tested it.