Write Reviews errors not going to the right page

[lat9]

Running 1.38a + security + FEC:

If javascript is disabled, so the error-checking falls within the server's realm, none of the input errors are displayed for the "Write a Review" page. The culprit appears to be \includes\modules\pages\product_reviews_write\header.php, starting at line 56:

  if (strlen($review_text) < REVIEW_TEXT_MIN_LENGTH) {
    $error = true;

    $messageStack->add('review_text', JS_REVIEW_TEXT);
  }

  if (($rating < 1) || ($rating > 5)) {
    $error = true;

    $messageStack->add('review_text', JS_REVIEW_RATING);
  }

Which should be:

  if (strlen($review_text) < REVIEW_TEXT_MIN_LENGTH) {
    $error = true;

    $messageStack->add('product_reviews_write', JS_REVIEW_TEXT);
  }

  if (($rating < 1) || ($rating > 5)) {
    $error = true;

    $messageStack->add('product_reviews_write', JS_REVIEW_RATING);
  }

[lat9]

... and then \includes\templates\template_default\tpl_product_reviews_write_default needs to add the following line to actually display the messages:

<?php if ($messageStack->size('product_reviews_write') > 0) echo $messageStack->output('product_reviews_write'); ?>
<div class="centerColumn" id="reviewsWrite">

[DrByte]

Actually, leaving the key as 'review_text' will work just fine on a clean default install, since the output for that key is already in the tpl_product_reviews_write_default.php file, on line 44:

<?php if ($messageStack->size('review_text') > 0) echo $messageStack->output('review_text'); ?>

So, it would appear that the "bug" is in your own template somewhere, and not in the default core code of v1.3.8a.

[lat9]

You are (as always) correct; it was my mess-up.