Strange error message re. PayPal Notifications

15 Nov 2009, 02:33

#1

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Strange error message re. PayPal Notifications

Prior to upgrading from 1.3.7 to 1.3.8a, I had an error on my site where order confirmations would not be sent to me or to the customer. I did get a payment receipt from Pay Pal, but I had no idea what the customer had bought. I had to write each person to ask.

Now I have upgraded and have not had done any test orders yet, but, while checking things out, I found the following error message. It appears in the admin area, via the pulldown for Customers>PayPal IPN.

1054 Unknown column 'p.zen_order_id' in 'on clause'
in:
[select count(*) as total from strpaypal as p left join strorders as o on o.orders_id = p.zen_order_id]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

I don't know where it originated. Can anyone please help me to find and correct it?

Thanks,
Catherine

15 Nov 2009, 03:27

#2

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

Sounds like you missed upgrading the /admin/paypal.php file, since it's looking for a "zen_order_id" field which was removed as part of the upgrade to v1.3.8. Looks like you're still using the older version of that file.

15 Nov 2009, 03:51

#3

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

I did that upgrade before upgrading the site. I just now removed and reinstalled both Pay Pal modules again in case I missed one before. The message is still there, though.

Do I need to go to the actual file, /admin/paypal.php and change some code manually?

Catherine

15 Nov 2009, 04:07

#4

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

Hmm, I just did a search/find for that string of code, using Text Wrangler, but it says it was not found in the document admin/paypal.php

15 Nov 2009, 04:12

#5

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

cpaulson:
[B]1054 Unknown column 'p.zen_order_id' in 'on clause'

Getting that error message in conjunction with upgrading to v1.3.8 and with Paypal, is a result of mismatched PHP files, typically resolved by properly upgrading the missed files.

15 Nov 2009, 04:20

#6

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

Do you know how I can find which file is missed and how to fix them?

15 Nov 2009, 04:40

#7

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

http://winmerge.sf.net
https://www.zen-cart.com/tutorials/index.php?article=108
http://www.zen-cart.com/wiki/index.php/Troubleshoot_-_Diagnosing_Obscure_Issues

15 Nov 2009, 04:59

#8

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

I have Text Wrangler, which is the Mac equivalent of Winmerg. I have read the tutorial, article 108 on upgrading and it got me in all sorts of trouble trying to change files. In the end, I had to start all over.

I don't see how I can compare the files from my old backup to the newly upgraded files since the Pay Pal ones from the old site won't be right for 1.3.8.

I have removed the Pay Pal modules from the admin area and reinstalled them. I thought that would upgrade them.

I will try the debugging utility linked in the other article but I'm always afraid I'll change something I shouldn't. I don't understand php code. Guess I'll have to leave it till morning since it's midnight here and I get up early.

15 Nov 2009, 05:02

#9

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

cpaulson:
I don't see how I can compare the files from my old backup to the newly upgraded files since the Pay Pal ones from the old site won't be right for 1.3.8.

You don't need to.

Your problem is that you've supposedly upgraded to v1.3.8, but some of your files aren't properly containing v1.3.8 code.
So, compare your files against clean v1.3.8 files, and reconcile any differences.

15 Nov 2009, 11:18

#10

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

Thank you, Dr.Byte,
That has gotten rid of the error message.

Your problem is that you've supposedly upgraded to v1.3.8, but some of your files aren't properly containing v1.3.8 code.
So, compare your files against clean v1.3.8 files, and reconcile any differences.

Does that mean I need to compare all the files in my store? I thought the upgrade would have applied any needed changs.

One more question...
Now that I've gone through the upgrade process, I know I am supposed to delete the install folder. But, do I leave the 1.3.8 uploaded folder in my store site or do I delete that, also?

The setup is:
store.stitchinthyme
/_all the folders that make up the site
/zen_cart 1.3.8

Catherine

15 Nov 2009, 23:45

#11

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

cpaulson:
Does that mean I need to compare all the files in my store?

That's what I'm saying, yes.

cpaulson:
I thought the upgrade would have applied any needed changs.

If you're saying you think the "upgrade" does any *automatic* updates to any files, you're mistaken.
ALL changes to ALL .php files are done MANUALLY, by YOU.
The zc_install "upgrade" step *ONLY* upgrades your DATABASE content. It doesn't do *anything* to the PHP files which run the logic of your site.

cpaulson:

Now that I've gone through the upgrade process, I know I am supposed to delete the install folder. But, do I leave the 1.3.8 uploaded folder in my store site or do I delete that, also?

If you created a temporary copy of your site in a separate folder+database in order to do a temporary staging of the upgrade process to isolate and resolve potential problems, and then afterwards you've also already re-done the *real* upgrade on the *real* live site and it's working properly, then you no longer need the temporary folder+database which you had created ... and those can be deleted.

You also need to delete the zc_install folder from your live store if you've already done the database upgrade step for the live store.

16 Nov 2009, 00:01

#12

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

If you're saying you think the "upgrade" does any *automatic* updates to any files, you're mistaken.
ALL changes to ALL .php files are done MANUALLY, by YOU.
The zc_install "upgrade" step *ONLY* upgrades your DATABASE content. It doesn't do *anything* to the PHP files which run the logic of your site.

Thanks. It looks like I have a lot of work to do. I found the tutorial to be very confusing. I was going through changing files, not knowing what I was doing or why. In frustration, I trashed the efforts and just upgraded into the real store and original database. I will now try to upgrade each file, but I wonder if I can just "merge" all the new files into the store. Would that work? If I compare files, I still won't know what I'm doing and I'll just be blindly applying all the changes anyway. Does that make sense?
Catherine

16 Nov 2009, 00:16

#13

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

If you do 2 compares as explained in the documentation it's much easier:
1. v1.3.7 (clean) vs your v1.3.7 customized site ---- shows you the things YOU changed or added via addons
2. your site vs v1.3.8a (clean) ---- now you merge just YOUR changes you identified from the first compare

Or, if you have a 3-way compare tool, like Araxis Merge, it's a lot simpler: v1.3.7 (clean) vs your own site vs v1.3.8a (clean) .... and just merge *your* stuff from your own site into the 1.3.8a code or vice-versa, giving you a final set of files which can be used as your testing site and eventually on your upgraded live site.

The 3-way approach makes it very fast and easy. Many people make it way more complicated than they need to.

16 Nov 2009, 00:30

#14

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

The main problem is that my 1.3.7 has files that were hacked. I made a backup before realizing the files were compromised. Although I spent a lot of time trying to fix all the corrupted files, I missed some things because some things were broken. Link icons were not showing in the admin area and I was not getting notices of orders placed nor were the customers. So comparing with my original store would not help me. Since I do not know php code, I will just have to stumble along adding whatever changes I find. I'll merge what I think I can do safely. I don't know if Text Wrangler can do a 3 way compare and I don't know another Mac program for doing this. I have to study the manual a bit more. I just downloaded it for this upgrade task.

Hopefully, I will eventually get through this.

16 Nov 2009, 00:57

#15

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

Maybe the right strategy is to try another approach:

1. keep your upgraded database, assuming you've run zc_install on it to bring it up to v1.3.8a.
2. use a clean set of v1.3.8a files
3. manually implement your template on the new files, perhaps rebuilding the template over again
4. manually apply any updated addons which you'd previously applied to your old store

Basically, starting fresh with the new files, but keeping the old data.

Using your merge tools can help with identifying which customizations are still important and need to be redone in the new site.

16 Nov 2009, 01:04

#16

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

That sounds like a good plan. Some of the upgrade seemed to take since my admin area icons showed up as soon as I ran the database upgrade. I'll so as you suggest. It sounds a lot less complex since I am not sure how to tell what might be compromised.

I did apply the security patches for 1.3.8 from the download I found in the forums. If it gets overwritten, I can do it again.

Thank you for your help.
Catherine

16 Nov 2009, 15:32

#17

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

Hi,
Things were working well and I guess I got a bit too enthusiastic about replacing files with the new ones.

I discovered I lost some of my formatting. On the categories pages, I had a column of images showing each item with a portion of the description for each beside it. Now I have the column of images all run together without any spacing between them and the text is missing. Here is an example. All the category pages are doing this.
http://www.store.stitchinthyme.com/index.php?main_page=index&cPath=44

Here is a different one. This one has an error text at the top, but I don't know where to locate the cause of it.
http://www.store.stitchinthyme.com/index.php?main_page=product_info&cPath=10_31&products_id=43
I have been searching and comparing, but I can't find which file controls this.

I've been checking all the css pages I can find as well as functions, index.php files, etc. Do you know where I should be looking to correct these?

Catherine

16 Nov 2009, 15:40

#18

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

Sounds like your /includes/languages/english/product_info.php file (or your customized version of the file at /includes/languages/english/YOUR_CUSTOM_FOLDER/product_info.php) is damaged ... ie: missing a large part of its content or has extra ?> tag in the middle just before the section that has

fine('ATTRIBUTES_PRICE_DELIMITER_PREFIX', ' ( ');
define('ATTRIBUTES_PRICE_DELIMITER_SUFFIX', ' )');
define('ATTRIBUTES_WEIGHT_DELIMITER_PREFIX', ' (');
define('ATTRIBUTES_WEIGHT_DELIMITER_SUFFIX', ') ')

16 Nov 2009, 18:06

#19

cpaulson

Zen Follower

Join Date:: Jul 2007
Posts:: 124
Plugin Contributions:: 0

Re: Strange error message re. PayPal Notifications

Thank you. There was blank line before the section you quoted. I fixed it and now I'm rid of the garbagey overlapping. It's amazing how one little thing can make such a messy looking page.

I still have the problem with the product images having no space between them and not having the descriptive text beside them as in the first link I gave.

Do you know which file controls that?

16 Nov 2009, 18:20

#20

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,506
Plugin Contributions:: 173

Re: Strange error message re. PayPal Notifications

Stylesheet maybe?