cod + shipping modules

[Maria Claudia]

this is a similar request to
"http://www.zen-cart.com/forum/showthread.php?t=148410&highlight=cash+delivery"

We offer 4 shipping methods of which 2 are cods however when non cod shipping is chosen cod payment still shows, originating confusion and some little losses on every order.
It seems quite easy to correct such behaviour in zencart but I do not even dream of making a change myself.
(super unzenned)
can you possibly help?
thanks

[Maria Claudia]

this is a similar request to
"http://www.zen-cart.com/forum/showthread.php?t=148410&highlight=cash+delivery"

We offer 4 shipping methods of which 2 are cods however when non cod shipping is chosen cod payment still shows, originating confusion and some little losses on every order.
It seems quite easy to correct such behaviour in zencart but I do not even dream of making a change myself.
(super unzenned)
can you possibly help?
thanks

Sorry, I forgot basic info Zen-cart 1.3.8a shipping modules are clones of table.php, multilanguage addon.
No oher payment modules apart cod one since this site is a new one
Thanks again for any help.

[Ajeh]

You could have the COD payment module check which shipping module is selected and disable it based on the results ...

You can test the value with:
$_SESSION['shipping']['id']

Example, Flat Rate flat shipping module would be:
flat_flat

Item Rate item shipping module would be:
item_item

USPS Express Mail would be:
usps_EXPRESS

Customize the COD Payment Module:
/includes/modules/payment/cod.php

An example of disabling COD if Flat Rate flat shipping module is selected would be:

      $this->enabled = ((MODULE_PAYMENT_COD_STATUS == 'True') ? true : false);

      // do not show COD when shipping is Flat Rate
      if ($_SESSION['shipping']['id'] == 'flat_flat') {
        $this->enabled = false;
      }

      if ((int)MODULE_PAYMENT_COD_ORDER_STATUS_ID > 0) {
        $this->order_status = MODULE_PAYMENT_COD_ORDER_STATUS_ID;
      }

[Maria Claudia]

Thank for your answer.

Actually my cod module says something different
line 43

// class methods
    function update_status() {
      global $order, $db;

      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_COD_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_COD_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {

supposing these are the lines you refer to.

[Ajeh]

Look in the top of the COD Payment at the
function cod() {

[Maria Claudia]

line 26

// class constructor
    function cod() {
      global $order;

      $this->code = 'cod';
      $this->title = MODULE_PAYMENT_COD_TEXT_TITLE;
      $this->description = MODULE_PAYMENT_COD_TEXT_DESCRIPTION;
      $this->sort_order = MODULE_PAYMENT_COD_SORT_ORDER;
      $this->enabled = ((MODULE_PAYMENT_COD_STATUS == 'True') ? true : false);

[Ajeh]

And if you put the code that I posted in RED below the BLACK line that reads:

      $this->enabled = ((MODULE_PAYMENT_COD_STATUS == 'True') ? true : false);

and before the BLACK line that reads:

      if ((int)MODULE_PAYMENT_COD_ORDER_STATUS_ID > 0) {

Does it work?

[Maria Claudia]

i am gonna do it and let you. thank you.

[Maria Claudia]

I have modified as follows:

    // do not show COD when shipping is PP
      if ($_SESSION['shipping']['id'] == 'table1') {
        $this->enabled = false;
      }

table1 is one of the two shipping methods non cod
in checking out I had following:

Sorry, we are not accepting payments from your region at this time.
Please contact us for alternate arrangements.

may be it is not working or I made a mistake here or somewhere else in admin setting ?

[Ajeh]

For a Table1 try using:
table1_table1

just like the examples ...