HTTP 500 error on PayPal site

[icikite]

Finally I find the error . It was a sentence in functions_taxes.php that is wrong and I still don't no why. If somebody have an idea it will be appreciate. The last sentence give me an error.( $tax is the value that cause the error. Strange because it was tested > then 0 before calling the las functions)
Thanks.


////
// Add tax to a products price based on whether we are displaying tax "in" the price
function zen_add_tax($price, $tax) {
global $currencies;

if ( (DISPLAY_PRICE_WITH_TAX == 'true') && ($tax > 0) ) {
return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']) + zen_calculate_tax($price, $tax);
} else {
return zen_round($price, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
}
}

// Calculates Tax rounding the result
function zen_calculate_tax($price, $tax) {
global $currencies;
// $result = bcmul($price, $tax, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// $result = bcdiv($result, 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// return $result;
return zen_round($price * $tax / 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
}

[JohnRoy]

You have found that error since Feb 21st and still no fix ... I have the same for the last couple of days ...

I hope someone figures this out ...

[icikite]

The error was happening in the function_taxes.php and here is the change I made:

Here what I change in function_taxes.php around line 170 (in bold)


// Calculates Tax rounding the result
function zen_calculate_tax($price, $tax) {
global $currencies;
// $result = bcmul($price, $tax, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// $result = bcdiv($result, 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// return $result;
if ( (is_numeric($tax) == 'true') && ($tax > 0) ) {

return zen_round($price * $tax / 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']); }
}

[DrByte]

I submit that the approach you've taken there will result in further problems if the $tax value is not numeric. Namely, what you've done there prevents *any* value from being returned, which means whatever asked for a tax calculation is going to get no results, thus resulting in incorrect calculations, and possibly even mismatched transaction/order amounts.

[DrByte]

Upon further investigation, the only reason for $tax not being numeric would be if you had entered non-numeric data for the tax rate when you set up your tax rates in your admin area.

.. which begs the question. How exactly are your tax zones and tax rates set up?

[icikite]

Here are my taxe rate:

Priority Tax Class Zone Tax Rate Action
1 Taxable Goods Canada GST zone 5.0%
1 Taxable Goods HST tax zone 13.0%
2 Taxable Goods Quebec PST zone 7.5%
1 Shipping Canada GST zone 5.0%
2 Shipping Quebec PST zone 7.5%
1 Shipping HST tax zone 13.0%
Displaying 1 to 6 (of 6 tax rates)


Taxe zone
GEND: : Taxes & Zones Defined : Zones Defined but not Taxes : Not Configured
Zone Name Zone Description Status Action
Canada GST zone GST (except: NS,NB,NL)
Florida Florida local sales tax zone
HST tax zone NS,NB,NL
Quebec PST zone PST( only when shipping to Quebec)
Displaying 1 to 4 (of 4 tax zones) Page 1 of 1

Notice that I had the problems only when returning from paypal. All taxes seams correct.