HTTP 500 error on PayPal site

[icikite]

The error was happening in the function_taxes.php and here is the change I made:

Here what I change in function_taxes.php around line 170 (in bold)


// Calculates Tax rounding the result
function zen_calculate_tax($price, $tax) {
global $currencies;
// $result = bcmul($price, $tax, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// $result = bcdiv($result, 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']);
// return $result;
if ( (is_numeric($tax) == 'true') && ($tax > 0) ) {

return zen_round($price * $tax / 100, $currencies->currencies[DEFAULT_CURRENCY]['decimal_places']); }
}

[DrByte]

I submit that the approach you've taken there will result in further problems if the $tax value is not numeric. Namely, what you've done there prevents *any* value from being returned, which means whatever asked for a tax calculation is going to get no results, thus resulting in incorrect calculations, and possibly even mismatched transaction/order amounts.