Need help calling variables

[philip937]

Hi everyone,

I am currently working on some code that will add
<meta name="ROBOTS" content="NOINDEX,FOLLOW">

on linked product pages.

in the html_header.php file I have added:

<?php
include('includes/meta_noindex.php');
?>

where meta_noindex.php is:

$check_linked = mysql_query('SELECT master_categories_id from products WHERE products_id = '.$prod_id.'');
$check_result_row = mysql_fetch_row($check_linked);
$catid = $check_result_row[0];

if ( $catid == $current_category_id ) {
} else {
$meta = '<meta name="ROBOTS" content="NOINDEX,FOLLOW">';
echo $meta;
} 

only problem is that having the code in the html_header there is no reference to the variables:
$prod_id
$current_category_id

Can anyone advise what I could do to get this to work??

Cheers
Phil

[kobra]

Use Developer tools and search for use of $prod_id

https://www.zen-cart.com/tutorials/index.php?article=38
https://www.zen-cart.com/tutorials/index.php?article=39

[philip937]

Use Developer tools and search for use of $prod_id

https://www.zen-cart.com/tutorials/index.php?article=38
https://www.zen-cart.com/tutorials/index.php?article=39

I did, thats how I knew the variable was $prod_id ! I need to know how my code can know the same $prod_id value that the tpl_product_info_display.php outputs...

?

[DrByte]

You could use the built-in functionality for $robotsNoIndex by putting your code into the end of init_add_crumbs.php and reworking it to set $robotsNoIndex under the conditions you desire.

There are other discussions for handling canonical matters also discussed elsewhere on the forum.

[philip937]

You could use the built-in functionality for $robotsNoIndex by putting your code into the end of init_add_crumbs.php and reworking it to set $robotsNoIndex under the conditions you desire.

There are other discussions for handling canonical matters also discussed elsewhere on the forum.

Thanks BrByte,

Any chance of a bit of guidance with the init_add_crumbs.php file?

I tried my code in the bottom and also inside the if (isset($_GET['products_id'])) { part, but neither had the desired affect.

My code has the correct logic, it compares the current category with the master and I set it to set the $robotsNoIndex, but it was doing this regardless for some reason?

Phil

[DrByte]

Actually, I take part of that back. I'd recommend just adding the following to the bottom of your init_category_path.php file:

// set noindex, nofollow on linked products
if ($current_category_id > 0 && $current_category_id != zen_get_products_category_id($_GET['products_id']) ) $robotsNoIndex = TRUE;

(replacing the line with just ?> on it, if it exists, or just adding to the end of the file if the ?> doesn't exist.)
https://www.zen-cart.com/tutorials/i...hp?article=313

[philip937]

Actually, I take part of that back. I'd recommend just adding the following to the bottom of your init_category_path.php file:

// set noindex, nofollow on linked products
if ($current_category_id > 0 && $current_category_id != zen_get_products_category_id($_GET['products_id']) ) $robotsNoIndex = TRUE;

(replacing the line with just ?> on it, if it exists, or just adding to the end of the file if the ?> doesn't exist.)
https://www.zen-cart.com/tutorials/i...hp?article=313

DrByte,

Thanks I almost got this working I think, however your suggestion seems to have 2 issues I can see so far (assuming I followed your instructions correctly?)

the noindex seemed to be included in the product in the master category and not on the linked the opposite to the desired effect,

also after adding it i noticed its adding the noindex to tag to the category pages too :o(

here is what I did, perhaps you might point out if I have done it wrong?

so the edit to init_category_path.php file looks like this:

if ($current_category_id > 0 && $current_category_id != zen_get_products_category_id($_GET['products_id']) ) $robotsNoIndex = TRUE;

I also tried without the closing ?> tag, same result

[DrByte]

Maybe try this instead of what I posted earlier?

if ($current_page != 'index' && isset($_GET['products_id']) && $current_category_id > 0 && $current_category_id != zen_get_products_category_id($_GET['products_id']) ) $robotsNoIndex = TRUE;

Again, there are other discussions for more focused canonical handling already kicking around the forum.

[philip937]

Thats works perfect but its still does the opposite i.e sets

no index no follow on the master category and not the linked rather than the other way around??

I even went into my category link manager to check that the master cat that it should have been was actually set right and it was...

I'm trying to work out how your code is working? my original one compared the current category id with the master for the current product, is this how yours is working to?

I tried removing the ! as I thought it might reverse the logic but that just set noindex on both.

This is so close...

I have search around the forums and can't find any similar topics.

[DrByte]

I'm not sure why you're having any problem with it, since zen_get_products_category_id gives you the master, and $current gives you the current one, and it's already comparing those for mismatch.

This tests fine for me:

//Robots no-index on product pages not using master_categories_id:
if ($current_page != 'index' && isset($_GET['products_id']) && $current_category_id > 0 && $current_category_id != zen_get_products_category_id($_GET['products_id']) ) $robotsNoIndex = TRUE;

Although, it only deals with product pages, and not category pages.

However, as I've eluded to before, I'd recommend a different approach altogether: proper canonical handling.