Results 1 to 10 of 84

Hybrid View

  1. #1
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,915
    Plugin Contributions
    13

    Default Re: All Invoices Report [support]

    hi,
    i just started looking at this module for a specific need. while it does get installed on the admin side; i would still cleanse the $orderStatus variable prior to its use. from:

    PHP Code:
    $orderStatus $_GET['status']; 
    to

    PHP Code:
    $orderStatus zen_db_prepare_input($_GET['status']); 
    or perhaps making use of the bindVars instead.

    i have a need to print a range of invoices; i am not sure if others have a need for that. which seems like easy enough to do. however, on first glance, this does look to be like a valuable module. thanks!
    author of square Webpay.
    mxWorks now has Apple Pay and Google Pay. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  2. #2
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    13,948
    Plugin Contributions
    96

    Default Re: All Invoices Report [support]

    Good point, carlwhat, I'll add that to the plugin's change-list. I'm not as concerned about the sanitizing since it's on the admin side.

  3. #3
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,915
    Plugin Contributions
    13

    Default Re: All Invoices Report [support]

    lat9,
    which one was the good point: adding an invoice range? or sanitizing the $_GET variables?

    i agree, the sanitizing is not as big a concern as it is on the admin side. the invoice range is for what i needed the module. i suppose the tricky part is what invoices to include, as we have a cancelled order status which we do not want to see; but then all of other statuses we do.

    i suppose the selection process could go on and on...

    in addition, we implemented the super_orders and super_invoices module, so i needed to modify the formatting of the invoice to match that...

    that said, a very helpful starting point for me. thanks again for this contribution.

    best.
    author of square Webpay.
    mxWorks now has Apple Pay and Google Pay. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  4. #4
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    13,948
    Plugin Contributions
    96

    Default Re: All Invoices Report [support]

    carlwhat, I was responding to the need to sanitize the $_GET variable (just using a simple integer-cast is sufficient).

    I'll add the order-range specification as a change-request to the plugin.

  5. #5
    Join Date
    Jun 2010
    Location
    Austria
    Posts
    115
    Plugin Contributions
    0

    Default Re: All Invoices Report [support]

    Just a quick query if there's an updated version for 1.5.5a in the pipeline? Thank you for making this available!

  6. #6
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    13,948
    Plugin Contributions
    96

    Default Re: All Invoices Report [support]

    Quote Originally Posted by terraGirl View Post
    Just a quick query if there's an updated version for 1.5.5a in the pipeline? Thank you for making this available!
    Should be good-to-go! That's one of the benefits (usually) of a no-core-file-overwrites plugin.

  7. #7
    Join Date
    Jan 2004
    Posts
    66,446
    Plugin Contributions
    81

    Default Re: All Invoices Report [support]

    Hi lat9,
    I just submitted an update (called it 2.5) which allows the storeowner to optionally update all the selected orders' status after generating the report.
    It involved rearranging a couple things between files.

    And the foreach which loops thru orders is v1.5.5 specific. I guess it could be changed to a "while !EOF, MoveNext()" if really needed on older versions.

    https://www.zen-cart.com/downloads.php?do=file&id=1083
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. v152 Support Thread: Report All Errors (Even Warnings)
    By lat9 in forum Addon Admin Tools
    Replies: 34
    Last Post: 1 Feb 2020, 05:42 PM
  2. v154 Editable Invoices & Packing Slips [Support]
    By dbltoe in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 7 Oct 2015, 11:44 PM
  3. Replies: 1
    Last Post: 27 Jan 2012, 06:35 PM
  4. Admin Activity Report [support thread]
    By Steven300 in forum All Other Contributions/Addons
    Replies: 17
    Last Post: 6 Aug 2009, 12:47 PM
  5. printing all invoices
    By simplesat in forum General Questions
    Replies: 1
    Last Post: 28 Nov 2008, 04:03 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg