[Done v1.3.8] Banner manager

[draftdesign]

When looking at the banner list, clicking on "Status - Enable" and trying to re-enable the banner by clicking the "Status" icon produce the following error.

-----------------------------------------------------------------------------------------
1292 Incorrect datetime value: '' for column 'date_scheduled' at row 1
in:
[update banners set status = 1, date_status_change = now(), date_scheduled = '' where banners_id = '13']
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
------------------------------------------------------------------------------------------

Let me know if anybody knows how to fix this issue.

tx

[DrByte]

What version of Zen Cart?
What version of MySQL ?

[draftdesign]

What version of Zen Cart?
What version of MySQL ?

Zen Cart 1.3.7
MySQL 5.0.27-community-nt

[DrByte]

I would suggest this:

/includes/functions/banner.php
around line 14 you have this:

  function zen_set_banner_status($banners_id, $status) {
    global $db;
    if ($status == '1') {
      $sql = "update " . TABLE_BANNERS . "
              set status = 1, date_status_change = now(), date_scheduled = ''
              where banners_id = '" . (int)$banners_id . "'";

      return $db->Execute($sql);

    } elseif ($status == '0') {

make the following change shown in red (remove the quotes and replace with NULL):

  function zen_set_banner_status($banners_id, $status) {
    global $db;
    if ($status == '1') {
      $sql = "update " . TABLE_BANNERS . "
              set status = 1, date_status_change = now(), date_scheduled = NULL
              where banners_id = '" . (int)$banners_id . "'";

      return $db->Execute($sql);

    } elseif ($status == '0') {

[draftdesign]

Worked like a charm!

tx

Pierre

[live2learn]

Is this a bug? I was wondering why it still exists in the newest version of V 1.3.9.C

[DrByte]

Is this a bug? I was wondering why it still exists in the newest version of V 1.3.9.C

I can't replicate the problem in v1.3.9c

What version of PHP and MySQL are you using?