Advance Search Results SQL syntax error after 1.3.9b upgrade

[chrisruggia]

Hello Everyone,

I have upgraded http://www.fsbooks.com/shop/ to 1.3.9b with (I thought) no problems.

But I just discovered that my advanced search results are generating the following error:

"1064 You have an error in your SQL syntax; ...."

The syntax error seems to be that the "order by" clause is duplicated at the end of the SQL request.

I dug through includes>modules>pages>advanced_search_result>header_php.php over and over, but couldn't figure out why it was generating the error.

THEN I noticed that the breadcrumbs are ALSO duplicated. It appears that for some reason this particular header_php.php file is being called twice. The problem doesn't occur on any other pages that I can find.

Can anyone give me some ideas how this might happen, and where I might look for a fix?

Here's a link for a search showing the problem:
http://www.fsbooks.com/shop/index.ph...=&pto=&x=0&y=0

Any suggestions very gratefully appreciated.

[DrByte]

How many header_php files are in that folder?
Remember: ALL "backup" files should NEVER use the original ".php" or ".css" or ".js" extension. If you're going to make backups by renaming a file, ALWAYS use a different file extension, like ".bak"

[chrisruggia]

I had no idea!

When I have edited the SQL calls in the header_php files, I've just added "-OLD" before the suffix to keep a copy of the original file.

I'm not too optimistic, though, because I have half a dozen others similarly edited and backed up without causing the issue.

I will change all the suffixes and report back.

THANKS for the tip!

[chrisruggia]

I wasn't optimistic, but I was completely wrong because the issue was fixed by removing the backup file with its .php extension.

Now re-renaming all of my backup files.

Best practice, here I come!

DrByte, you are my favorite person today. THANK YOU!