[Done v1.5.0] minor email table error in orders.php

[torvista]

in /includes/classes/order.php
the code results in a missed starting <tr> tag and a final extra <tr> in the email.

Suggested change from:

    //order totals area
    $html_ot .= '<td class="order-totals-text" align="right" width="100%">' . '&nbsp;' . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' . '---------' .'</td> </tr>' . "\n" . '<tr>';
    for ($i=0, $n=sizeof($order_totals); $i<$n; $i++) {
      $email_order .= strip_tags($order_totals[$i]['title']) . ' ' . strip_tags($order_totals[$i]['text']) . "\n";
      $html_ot .= '<td class="order-totals-text" align="right" width="100%">' . $order_totals[$i]['title'] . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' . "\n" . '<tr>';
    }

to:

    //order totals area
    $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' . '&nbsp;' . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' . '---------' .'</td> </tr>' . "\n";
    for ($i=0, $n=sizeof($order_totals); $i<$n; $i++) {
      $email_order .= strip_tags($order_totals[$i]['title']) . ' ' . strip_tags($order_totals[$i]['text']) . "\n";
      $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' . $order_totals[$i]['title'] . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' . "\n";
    }

whether you get rid of the "nowrap" tags and put them in the css is another matter.

[DrByte]

whether you get rid of the "nowrap" tags and put them in the css is another matter.

Email typically doesn't support most CSS usage, hence the choice to embed it into the HTML.

However, the incorrect nesting is fixed in v1.5.0

[choccybox]

Hi,

In the includes/classes/orders.php files there is a code for outputting the order totals in the order confirmation email. The coding is:

$html_ot .= '<td class="order-totals-text" align="right" width="100%">' . '&nbsp;' . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' . '---------' .'</td> </tr>' . "\n" . '<tr>';
for ($i=0, $n=sizeof($order_totals); $i<$n; $i++) {
$email_order .= strip_tags($order_totals[$i]['title']) . ' ' . strip_tags($order_totals[$i]['text']) . "\n";
$html_ot .= '<td class="order-totals-text" align="right" width="100%">' . $order_totals[$i]['title'] . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' . "\n" . '<tr>';
}
$html_msg['ORDER_TOTALS'] = '<table border="0" width="100%" cellspacing="0" cellpadding="2"> ' . $html_ot . ' </table>';

Now this gives a html output of:

<table border="0" width="100%" cellspacing="0" cellpadding="2"> <td class="order-totals-text" align="right" width="100%">&nbsp;</td>
<td class="order-totals-num" align="right" nowrap="nowrap">---------</td> </tr>
<tr><td class="order-totals-text" align="right" width="100%">Sub-Total:</td>
<td class="order-totals-num" align="right" nowrap="nowrap">$8.00</td> </tr>
<tr><td class="order-totals-text" align="right" width="100%">Per Item Rates (Shipping to BS (145.00grams)):</td>
<td class="order-totals-num" align="right" nowrap="nowrap">$3.30</td> </tr>
<tr><td class="order-totals-text" align="right" width="100%">Total:</td>
<td class="order-totals-num" align="right" nowrap="nowrap">$11.30</td> </tr>
<tr> </table>

Forgive me if i'm wrong, but there seems to be a missing <tr> before the first <td> tag. e.g.

<table border="0" width="100%" cellspacing="0" cellpadding="2"> <TR><td class="order-totals-text" align="right" width="100%">&nbsp;</td>
<td class="order-totals-num" align="right" nowrap="nowrap">---------</td> </tr>


Therefore shouldn't the orders.php code be:

$html_ot .= '<TR><td class="order-totals-text" align="right" width="100%">' . '&nbsp;' . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' . '---------' .'</td> </tr>' . "\n" . '<tr>';
for ($i=0, $n=sizeof($order_totals); $i<$n; $i++) {
$email_order .= strip_tags($order_totals[$i]['title']) . ' ' . strip_tags($order_totals[$i]['text']) . "\n";
$html_ot .= '<td class="order-totals-text" align="right" width="100%">' . $order_totals[$i]['title'] . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' . "\n" . '<tr>';
}
$html_msg['ORDER_TOTALS'] = '<table border="0" width="100%" cellspacing="0" cellpadding="2"> ' . $html_ot . ' </table>';

[choccybox]

I tested the code suggested:

 //order totals area
    $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' . '&nbsp;' . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' . '---------' .'</td> </tr>' . "\n";
    for ($i=0, $n=sizeof($order_totals); $i<$n; $i++) {
      $email_order .= strip_tags($order_totals[$i]['title']) . ' ' . strip_tags($order_totals[$i]['text']) . "\n";
      $html_ot .= '<tr><td class="order-totals-text" align="right" width="100%">' . $order_totals[$i]['title'] . '</td> ' . "\n" . '<td class="order-totals-num" align="right" nowrap="nowrap">' .($order_totals[$i]['text']) .'</td> </tr>' . "\n";
    } 

And html emails now seem to work fine in hotmail, gmail, yahoo & windows live mail.

Thanks guys!