Discounting rounding errors (Product Price Manager > Qty Discounts)

[stride-r]

ZC 1.3.8a

We've run into an issue where ZC seems to be rounding discounts when we think they should not.

Example where an item is set to give a (20% discount when purchasing 10 or more):

50 widgets @ reg price of $1.24 = $.992 ea. after discount
Total with discount = $49.60

Yet Zen Cart Calculates this to a total of $49.50
It appears that the discount applied to the per-item-price is rounded immediately to .99 rather than .992


Anyone know how to fix this????

[Ajeh]

This is working in v1.3.9 where you would get the:

50 widgets @ reg price of $1.24 = $.992 ea. after discount
Total with discount = $49.60

[stride-r]

Do you know where/what file or files are involved that affects this calculation? Upgrading the entire cart from 1.3.8a to 1.3.9 is not entirely practical at the moment ...but if there is a simple code or function replacement where i can pull it from 1.3.9 and paste it into 1.3.8, that'd be cool for the moment.

If you or someone could point me in the right direction of the affected files (if doing this is possible), that would be greatly appreciated!

[Ajeh]

Off the top of my head, no ...

I was looking to see if that difference might have been posted separately as a fix but there were a number of changes to pricing, discounts etc. and it is difficult to mark it as just one thing to be fixed ...

You can try downloading a clean v1.3.8 and a clean v1.3.9 and try doing a compare but by the time you figured it out, you might as well upgrade ...

[henrytan]

Hi Ajeh,
Do you know which file is the one that we need to change to effect this change?

I have the same issue, and although i upgraded, the issue does not seem to be solved.

Is it in includes/classes/shopping_cart.php?

Henry

[Ajeh]

There are so many differences between v1.3.8 and v1.3.9 that affect prices that I really haven't the time to hunt down the change(s) needed to fix this ...

I'd say upgrading would be faster ...

You might try a test install of the current version of Zen Cart from our Home page, in a test directory with a test database, and enter a few products that you are currently having issues with and test this ...