reopen thread [Done v1.3.9] Discount groups and tax calc problem with tax-included pr

[antonios]

I'm running 1.3.9d and still have the same tax problems as in 1.3.8 involving tax calculation and group discounts
The issue is said to be solved in 1.3.9 but it isn't

Here's what's happening:

These results are all correct when buying a product with free shipping:

Sub-Total:€16.95
Free Shipping Options (Free Shipping):€0.00
Group Discount:-€5.09
TAX 6%:€0.67
Total:€11.86

I was very happy about this, since this wasn't working correct in 1.3.8. But now there's the problem when adding shipping costs/tax

Once I choose flat rate shipping (TAX 19%) it messes up everything:

Sub-Total:€16.95
Flat Rate (Best Way):€5.65
Group Discount:-€4.82 -- incorrect
TAX 6%:€0.81 --incorrect
TAX 19%:€0.76 --incorrect
Total:€17.78 --incorrect

I've tried every sort order in ordertotal, every config in shipping and in grouppricing, nothing seems to help.

Please reopen this issue, or please help me with this.

Greetings Antonios

[pasi]

This does not only affect the group discount, but basicly every discount module... They are flawed.

I had to rewrite ALL of them to get a rest for my soul, because they were always calculating things wrong.

And no, it's not about settings, when you strip the code line by line and think it logically, you will realize that it calculates things wrong in it's logic... mostly regarding to shipping costs.

[antonios]

Hello Pasi,

Thanks for replying.
Glad it wasn't just me, thought I was missing something.

Can you tell me which lines you rewrote or is that too much to write down here.

Greetings Antonios

[wilt]

If you are running v139, then try this

In includes/modules/order_totals/ot_group_pricing.php at around line 67 you should see a commented out line

//    if ($this->include_tax != "true" && $this->include_shipping != 'true') $order_total += $order->info['shipping_tax']; 

and remove the // so the line is no longer commented, and test again.

Note. while I have tested this fix with some other variations of group discount and tax with no deleterious results, I have not tested enough combinations yet, to say whether its the correct fix for all use cases.

[antonios]

Hello Wilt,

I've tried your fix, but it doesn't make a difference.
I've tried it in combination with every possible setting but unfortunately it didn't help.

I'm getting really pissed off by this bug. Group discount is quite an essential feature for webshops, at least it is for ours.. It does work, if you don't charge shipping costs with tax which is obligatory in the netherlands.

Well, if anyone has a hint, please feel free to write it down.

Greetings Antonios

[wilt]

k, can you post what you expect the output to be.

I'm setting up something that uses all the settings you have, and will post back here shortly with what current code does output.