[Done v2.0] Incorrect Language Validation

[glenara]

I recently installed a second language and when I logged into the admin interface it reported an error:
MISSING LANGUAGE FILES OR DIRECTORIES

My operating system is a windows 2003 server.
The zen cart is 1.3.9d

The error is referring to the missing language in the admin section, which does not exist. Further testing shows that it is not checking for the existence of the language in the includes/language folder at all.

So what its doing is reporting an error on something that isn't and not even checking what it's supposed to be.

The issue is two fold, you may multiple languages in your website but only one in the admin section to administer the site.

If you add a language and it does not exist in the admin section you should not get an error. On the other hand, if you do have it in both your web site and the admin interface, it should be checked to be sure both the file and directory exist.

The code at the top of admin/includes/header.php is where this disaster is all happening: This is the un-edited code exactly as it's being distributed.

 // Show Languages Dropdown for convenience only if main filename and directory exists
if ((basename($PHP_SELF) != FILENAME_DEFINE_LANGUAGE . '.php') and (basename($PHP_SELF) != FILENAME_PRODUCTS_OPTIONS_NAME . '.php') and empty($action)) {
  $languages = zen_get_languages();
  if (sizeof($languages) > 1) {
    $languages_array = array();
    $languages_selected = $_GET['language'];
    $missing_languages='';
    for ($i = 0, $n = sizeof($languages); $i < $n; $i++) {
      $test_directory= DIR_WS_LANGUAGES . $languages[$i]['directory'];
      $test_file= DIR_WS_LANGUAGES . $languages[$i]['directory'] . '.php';
      if ( file_exists($test_file) and file_exists($test_directory) ) {
        $count++;
        $languages_array[] = array('id' => $languages[$i]['code'],
                                 'text' => $languages[$i]['name']);
//        if ($languages[$i]['directory'] == $language) {
        if ($languages[$i]['directory'] == $_SESSION['language']) {
          $languages_selected = $languages[$i]['code'];
        }
      } else {
        $missing_languages .= ' ' . ucfirst($languages[$i]['directory']) . ' ' . $languages[$i]['name'];
      }
    }

// if languages in table do not match valid languages show error message
    if ($count != sizeof($languages)) {
      $messageStack->add('MISSING LANGUAGE FILES OR DIRECTORIES ...' . $missing_languages,'caution');
    }
    $hide_languages= false;
  } else {
    $hide_languages= true;
  } // more than one language
} else {
  $hide_languages= true;
} // hide when other language dropdown is used 

This is, to say the least, a bit of a mess since its not doing any thing useful or correctly.

The correct way:
Once the languages listed in the db have been retrieved we need to check to see if the directory and file exists in the includes/languages directory, as these must exist.

While we're at it we can check to see it the same language is also being used in the admin section (but it doesn't have to be).

In the case of the website languages both the directory and file must exist or an error should be reported/generated.

If both parts do not exist in admin/includes/languages it should not be considered an error and ignored.
However, if one part exists, either the directory or the file, then it can or should be considered an error.

Here is how it can be done which addresses what I've been talking about.

// Check to see if each language directory and file exists.
// Create an Admin Languages Dropdown list of only those languages used by the admin interface.
$hide_languages= true; // first, initialize $hide_languages to get rid of all the crap in the else conditions that were at the end of this if statement
if ((basename($PHP_SELF) != FILENAME_DEFINE_LANGUAGE . '.php') and (basename($PHP_SELF) != FILENAME_PRODUCTS_OPTIONS_NAME . '.php') and empty($action)) {
  $languages_array = array();
  $languages = zen_get_languages();
  if (sizeof($languages) > 1) {
    $languages_selected = $_SESSION['language'];
    $missing_languages=$missing_admin_languages='';
    $count = 0;
    for ($i = 0, $n = sizeof($languages); $i < $n; $i++) {
      // Check for the catalog language directory and file
      $test_directory= DIR_FS_CATALOG_LANGUAGES . $languages[$i]['directory'] ;
      $test_file= DIR_FS_CATALOG_LANGUAGES . $languages[$i]['directory'] . '.php';
      $isFile = file_exists($test_file);
      $isDir = file_exists($test_directory);
      if ( !$isFile || !$isDir ) {
        if ( !$isFile && !$isDir ) { $missing_languages .= ' Missing directory: ' . $test_directory . ', and file: '. $test_file;}
        else if ( !$isDir ) { $missing_languages .= ' Missing directory: ' . $test_directory;}
        else { $missing_languages .= ' Missing file: ' . $test_file;}
      }
      // Check to see if this language is also being used by admin interface.
      $test_directory= DIR_WS_LANGUAGES . $languages[$i]['directory'] ;
      $test_file= DIR_WS_LANGUAGES . $languages[$i]['directory'] . '.php';
      $isFile = file_exists($test_file);
      $isDir = file_exists($test_directory);
      if ( $isFile and $isDir ) {
        $count++;
        $languages_array[] = array('id' => $languages[$i]['code'], 'text' => $languages[$i]['name']);
        if ($languages[$i]['directory'] == $_SESSION['language']) {
          $languages_selected = $languages[$i]['code'];
        }
      } else if ( !$isFile and !$isDir ) { // When both parts are missing it just means this language does not exist in the admin section 
        continue;
      } else {
        if ( !$isDir ) { $missing_admin_languages .= ' Missing directory: ' . DIR_WS_ADMIN . $test_directory;}
        else { $missing_admin_languages .= ' Missing file: ' . DIR_WS_ADMIN . $test_file;}
      }
    }
    if ( $missing_admin_languages !== '') {
      $messageStack->add('MISSING ADMIN LANGUAGE FILES OR DIRECTORIES ...' . $missing_admin_languages,'caution');
    }
    if ( $missing_languages !== '') { 
      $messageStack->add('MISSING CATALOG LANGUAGE FILES OR DIRECTORIES ...' . $missing_languages,'caution');
    }
    if($count > 1) $hide_languages = false;
  } 
} 

In the admin interface, the select language option list will only be generated if there is more than 1 language in the admin section.
And, it will only contain the languages in the admin/includes/langauges directory not all the languages listed in the database.


Well there you have it, do what you like with it.

[DrByte]

The issue is two fold, you may multiple languages in your website but only one in the admin section to administer the site.

If you add a language and it does not exist in the admin section you should not get an error.

One serious caveat: if you're corresponding with customers from your admin, all correspondence will happen in the selected language. So, if you're sending emails from your admin while in "English", then all your emails will go to the customer in English, even if the customer did their shopping in French or Spanish, or whatever. If you want the emails to be sent from the other language, you need to switch to that language first. But, if you haven't installed that language on your admin side, then ... well ... you won't be able to do that.
It's your customers who suffer when you don't install the admin-side language pack.

[glenara]

One serious caveat: if you're corresponding with customers from your admin, all correspondence will happen in the selected language. So, if you're sending emails from your admin while in "English", then all your emails will go to the customer in English, even if the customer did their shopping in French or Spanish, or whatever. If you want the emails to be sent from the other language, you need to switch to that language first. But, if you haven't installed that language on your admin side, then ... well ... you won't be able to do that.
It's your customers who suffer when you don't install the admin-side language pack.

Thanks for the feedback, but I'm not sure it's a caveat. Your point is well taken, however, if person chooses not to install the languages on the admin side then he won't get the annoying error persisting across the top of the page.

On the other hand this code segment still checks to see if both parts exist, ie that they match in the both the site and the admin sections. It will only be ignored if the entire admin section is missing which would be the installers choice.

In my initial effort to get rid of the message, I simply created an empty directory and added the file that contained the following:

<?php

exit("<div style='text-align:center; margin-top: 200px; color:red; font-weight: bold;'>There is no French admin section.<br>
      Use Back Button and select English.<br><br>
      ");

?>

This does address the fact the admin language has not been installed and gets rid of the error message. This is one way to deal with missing admin sections.

With that said and taking your caveat/warning into consideration, we could modify my code segment as follows:

// Check to see if each language directory and file exists.
// Create an Admin Languages Dropdown list of only those languages used by the admin interface.
$hide_languages= true; // first, initialize $hide_languages to get rid of all the crap in the else conditions that were at the end of this if statement
if ((basename($PHP_SELF) != FILENAME_DEFINE_LANGUAGE . '.php') and (basename($PHP_SELF) != FILENAME_PRODUCTS_OPTIONS_NAME . '.php') and empty($action)) {
  $languages_array = array();
  $languages = zen_get_languages();
  if (sizeof($languages) > 1) {
    $languages_selected = $_SESSION['language'];
    $missing_languages=$missing_admin_languages='';
    for ($i = 0, $n = sizeof($languages); $i < $n; $i++) {
      // Check for the catalog language directory and file
      $test_directory= DIR_FS_CATALOG_LANGUAGES . $languages[$i]['directory'] ;
      $test_file= DIR_FS_CATALOG_LANGUAGES . $languages[$i]['directory'] . '.php';
      $isFile = file_exists($test_file);
      $isDir = file_exists($test_directory);
      if ( !$isFile || !$isDir ) {
        if ( !$isFile && !$isDir ) { $missing_languages .= ' Missing directory: ' . $test_directory . ', and file: '. $test_file;}
        else if ( !$isDir ) { $missing_languages .= ' Missing directory: ' . $test_directory;}
        else { $missing_languages .= ' Missing file: ' . $test_file;}
      }
      // Check to see if this language is also being used by admin interface.
      $test_directory= DIR_WS_LANGUAGES . $languages[$i]['directory'] ;
      $test_file= DIR_WS_LANGUAGES . $languages[$i]['directory'] . '.php';
      $isFile = file_exists($test_file);
      $isDir = file_exists($test_directory);
      if ( $isFile and $isDir ) {
        $languages_array[] = array('id' => $languages[$i]['code'], 'text' => $languages[$i]['name']);
        if ($languages[$i]['directory'] == $_SESSION['language']) {
          $languages_selected = $languages[$i]['code'];
        }
      } else if ( !$isFile and !$isDir ) { // When both parts are missing it just means this language does not exist in the admin section 
        $languages_array[] = array('id' => $languages[$i]['code'], 'text' => $languages[$i]['name'] . ' (not installed)');
      } else {
        if ( !$isDir ) { $missing_admin_languages .= ' Missing directory: ' . DIR_WS_ADMIN . $test_directory;}
        else { $missing_admin_languages .= ' Missing file: ' . DIR_WS_ADMIN . $test_file;}
      }
    }
    if ( $missing_admin_languages !== '') {
      $messageStack->add('MISSING ADMIN LANGUAGE FILES OR DIRECTORIES ...' . $missing_admin_languages,'caution');
    }
    if ( $missing_languages !== '') { 
      $messageStack->add('MISSING CATALOG LANGUAGE FILES OR DIRECTORIES ...' . $missing_languages,'caution');
    }
    if(sizeof($languages) > 1) $hide_languages = false;
  }
} 

Now, the drop-down list is created but next to the missing language(s) it reads: French (not installed)

This might be the best of both worlds. It keeps the user informed about the languages missing in the admin side without creating the MISSING LANGUAGE FILES OR DIRECTORIES ... error, but still generates the error if there is file/directory mismatch.

In my clients case, he'll be responding in English regardless because he doesn't know any French.

In his case he is offering all his products in French although he doesn't speak it.

I suspect there are a lot of others that do the same thing, ie offer there products in languages they don't speak.

Anyway, good point and I think we'll have to look at how we handle our auto responses. (possibly a partial admin section to deal with the language email responses)

Thanks for the constructive criticism.

[DrByte]

Your points are understood. Thanks for the suggestions.

[FrilansReklam]

This points is also important for orders.php page.

It should be great if it is not made for the language the order is made in. As I wrote in another bug post.

All important point in this post is that I tryed to say in that post.

No part of the administration should be in need of a specific language. Im not thinking about the invoice function and packing list because it still has to be in the language the order was in but then this post point is important.

[DrByte]

This points is also important for orders.php page.

It should be great if it is not made for the language the order is made in. As I wrote in another bug post.

All important point in this post is that I tryed to say in that post.

No part of the administration should be in need of a specific language. Im not thinking about the invoice function and packing list because it still has to be in the language the order was in but then this post point is important.

I don't dispute that it's undesirable that the admin can only email in the language currently in use by the administrator.
But, to fix that is extremely difficult in Zen Cart v1.x.x.
However, due to some slick architectural changes in v2.x, it's looking like we'll be able to make it send emails in the language used by the customer when the purchase was made.

So ... while you may want to raise numerous bug reports about the fact that you don't like that it can only send from one language, it's not going to be fixed in Zen Cart v1.x.x. Stay tuned for v2.x in the near future, where it'll be more possible. Until then, duplicate bug reports about your wished feature will be ignored. Sorry.

And please don't hijack someone else's discussion of a very different matter just to slide in your complaint another time.