Any problem if I use ec_cancel to redirect to shopping cart?

[kiddo]

Hey Zen folks;

I will try to pose this clearly as I may.

On a site (1.3.9.alphabetsoup) I have both Paypal (the big yellow button) and Google checkout that show up on the shopping cart page. This is very nice.

When you go to Google but use the 'edit your order" link, you are brought back to the shopping cart page. Again very nice.

But, when you go to Pay pal via the big yellow button, and choose to return to the site via the "return to merchant link" at the bottom of the page, you go back to the ZC login page, not the shopping cart. This is not so nice.

Further, if you happen to be logged in to ZC already, and use the return to merchant link, you find yourself on the ZC shipping method page. Really not nice...

Now to the meat of my question.

In each case, when you return from paypal, the $_GET['ec_cancel'] is set to "1".

So, is there any badness to happen if I test for the ec_cancel flag on the login and shipping pages and if set, redirect back to the shopping cart?

perhaps something like:

if(isset($_GET['ec_cancel'])
  {
  redirect(... to shopping cart... sensible...);
  exit();
  }

This makes sense to me, but is there some unfortunate "gotcha" I'm overlooking?

Thanks!

[kiddo]

Well, it does seem to work with no bad things so far and returns canceled paypal back to the shopping cart page, but oddly the actual var name is $_GET['amp;ec_cancel'] NOT $_GET['ec_cancel']

Weird.

So in the proper /modules/pages.header.php files, using:

if(isset($_GET['amp;ec_cancel']))

	{
	header("Location: /index.php?main_page=shopping_cart");
	exit();
	}

seems to make the Paypal button and Google button act the same way.

[Kim]

Hacking in those edits is not recommended.
Your issue was fixed. Upgrade your files to the most recent version.