Results 1 to 2 of 2
  1. #1
    FredSchenk Guest

    bug [Not a bug] logical Error in admin/functions/html_output

    The function zen_draw_from in html_output starts with the following code:
    Code:
      function zen_draw_form($name, $action, $parameters = '', $method = 'post', $params = '', $usessl = 'false') {
        $form = '<form name="' . zen_output_string($name) . '" action="';
        if (zen_not_null($parameters)) {
          if ($usessl) {
            $form .= zen_href_link($action, $parameters, 'NONSSL');
          } else {
            $form .= zen_href_link($action, $parameters, 'NONSSL');
          }
        } else {
          if ($usessl) {
            $form .= zen_href_link($action, '', 'NONSSL');
          } else {
            $form .= zen_href_link($action, '', 'NONSSL');
          }
        }
    This looks like a logical error to me. I would expect the first and the third "NONSSL" to be "SSL"...
    Last edited by FredSchenk; 19 Oct 2010 at 12:14 AM. Reason: colorcodes for more clearity

  2. #2
    Join Date
    Jan 2004
    Posts
    66,444
    Plugin Contributions
    279

    Default Re: logical Error in admin/functions/html_output

    When the admin is reworked to handle SSL on all "select" pages, then those parameters will be changed.
    As it stands now, the *correct* way to get SSL protection on *all* admin pages is to use an HTTPS address in the HTTP_SERVER setting of your admin configure.php file.

    There are known problems with trying to flip back and forth between SSL and NONSSL inside the admin. Those are being addressed in the 2.0 release, and appropriate changes will be made at that time.

    Until then, that section of code should *not* be changed.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. v151 Plugin authors: Overrides of /includes/functions/html_output.php
    By lat9 in forum Contribution-Writing Guidelines
    Replies: 2
    Last Post: 3 May 2014, 08:48 AM
  2. [Not a bug] Missing double quotes in html_output.php
    By ckosloff in forum Bug Reports
    Replies: 4
    Last Post: 12 Aug 2009, 02:18 AM
  3. Overriding functions/html_output.php
    By kokuryu in forum Templates, Stylesheets, Page Layout
    Replies: 3
    Last Post: 16 Mar 2009, 08:02 PM
  4. Can I override functions/html_output ?
    By Minnie Mouse in forum Templates, Stylesheets, Page Layout
    Replies: 7
    Last Post: 20 Aug 2008, 06:00 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg