PayPal Payment Pro, no 'Decline error"?

[infocom]

I'm using the built in Paypal Website Payments Pro and Express Checkout modules, and I also do not get an error. Just returns me to the payment page with no error.

I have not modified the tpl_checkout_payment_default.php page, the messageStack code is there in the template_default/template/tpl_checkout_payment_default.php file.

I'm on 1.3.9d

[divinelighting]

Apparently, we are having a similar problem. It's been happening for some time, though I just found out about it.

Message Stack shows some errors, like invalid CC number, and incorrect CCV code. However, when the billing address is incorrect, it comes back to the payment page with no error.

Also, I received an "Internal Error" when a cc had insufficient funds. That seams misleading.

Using paypal pro and express checkout.
v1.3.9h

[numinix]

I find it doesn't show if the error code is 15005, but it works if it is 15006 or another error message. I don't see any reference to these error codes in the payment module though...

[kevinmc3]

Do you also have Fast Easy Checkout installed ? I think that may be the culprit

Apparently, we are having a similar problem. It's been happening for some time, though I just found out about it.

Message Stack shows some errors, like invalid CC number, and incorrect CCV code. However, when the billing address is incorrect, it comes back to the payment page with no error.

Also, I received an "Internal Error" when a cc had insufficient funds. That seams misleading.

Using paypal pro and express checkout.
v1.3.9h

[divinelighting]

Do not have Fast and Easy Checkout installed.

About the only mod we use that is active during checkout is Quantity Discounts by That Software Guy.

Still wondering why message stack does not show when AVS mismatch.

[niccol]

Has anyone had more luck with this. One of my sites has this issue. It is still 1.3.9h and there are no changes to the files in question. As numinix says the issue seems to occur just with 15005 errors and seems a bit intermittent. So a nightmare to reproduce...

[divinelighting]

Has anyone had more luck with this. One of my sites has this issue. It is still 1.3.9h and there are no changes to the files in question. As numinix says the issue seems to occur just with 15005 errors and seems a bit intermittent. So a nightmare to reproduce...

We have put this in "the cost of doing business" category. Lets me sleep at night.

[numinix]

I'm surprised this hasn't been resolved yet. It's a widespread issue with a module that comes with Zen Cart.

Anyways, I've debugged further and found that in paypaldp.php if the error code is 15005, then the function terminateEC will have a blank value for the $error_msg parameter on line 1758.

This is coming from line 1853:
$detailedMessage = ($errorText == MODULE_PAYMENT_PAYPALDP_INVALID_RESPONSE || $errorText == MODULE_PAYMENT_PAYPALDP_TEXT_DECLINED || $this->enableDebugging || $response['CURL_ERRORS'] != '' || $this->emailAlerts) ? (isset($response['RESULT']) && $response['RESULT'] != 0 ? MODULE_PAYMENT_PAYPALDP_CANNOT_BE_COMPLETED . ' (' . $errorNum . ')' : $errorNum) . ' ' . urldecode(' ' . $response['L_SHORTMESSAGE0'] . ' - ' . $response['L_LONGMESSAGE0'] . ' ' . $response['CURL_ERRORS']) : '';

Likely while the Zen Cart developers were testing this, they had enableDebugging true so this worked every time. But with it disabled, all the other conditions are failing. The reason they are failing is because $errorText is getting reassigned above and so it will never match the MODULE_PAYMENT_PAYPALDP_INVALID_RESPONSE or MODULE_PAYMENT_PAYPALDP_TEXT_DECLINED definitions.

So, bandaid solution is to enable debugging or email alerts. But ultimately this needs to be fixed for those who do not want to receive an email every time a customer's credit card declines.

[DrByte]

This is coming from line 1853:
$detailedMessage = ($errorText == MODULE_PAYMENT_PAYPALDP_INVALID_RESPONSE || $errorText == MODULE_PAYMENT_PAYPALDP_TEXT_DECLINED || $this->enableDebugging || $response['CURL_ERRORS'] != '' || $this->emailAlerts) ? (isset($response['RESULT']) && $response['RESULT'] != 0 ? MODULE_PAYMENT_PAYPALDP_CANNOT_BE_COMPLETED . ' (' . $errorNum . ')' : $errorNum) . ' ' . urldecode(' ' . $response['L_SHORTMESSAGE0'] . ' - ' . $response['L_LONGMESSAGE0'] . ' ' . $response['CURL_ERRORS']) : '';

Thanks for the detailed report.
I haven't done any regression testing on this yet, but it appears that replacing $this->enableDebugging with $this->enableDebugging || (int)trim($errorNum) > 0 appears to solve the specific problem stated.