[Not a Bug] Negative attribute price factor not working

[lat9]

Running 1.50 BETA 20110828. I have a product defined with a negative attribute price factor and while the price factor displays as a negative value in my admin ... it was not being applied in my storefront (also verified on a clean install of the beta).

The fix was to make the following four changes to /includes/classes/shopping_cart.php:

//           if ($attribute_price->fields['attributes_price_factor'] > 0) {  /* Line 758 */
           if ($attribute_price->fields['attributes_price_factor'] != 0) { 

//            if ($attribute_price->fields['attributes_price_factor_onetime'] >0) {  /* Line 784 */
           if ($attribute_price->fields['attributes_price_factor_onetime'] != 0) {  

//          if ($attribute_price->fields['attributes_price_factor'] > 0) { /* Line 927 */
          if ($attribute_price->fields['attributes_price_factor'] != 0) {

//          if ($attribute_price->fields['attributes_price_factor_onetime'] > 0) { /* Line 1011 */
          if ($attribute_price->fields['attributes_price_factor_onetime'] != 0) {

[Ajeh]

What values were you using?

Did you have this issue in v1.3.9h or are you just testing the fun stuff?

[lat9]

I defined a dropdown attribute name with two attribute values:

"Regular" ... using all defaults
"Price Factor" ... setting price factor to -0.5 and offset 0

The same problem exists in the v1.3.9h version of shopping_cart.php (seen by inspection); I'm actually defining a new storefront via the beta.

[Ajeh]

And if used, as intended, with:
One Time Factor: 1
Offset: 1.5

does it now work correctly on both Admin and Catalog?

[lat9]

Ajeh, I plugged in the numbers like you said and the result is a 1/2 off value (as I wanted/expected).

If a negative value of the 'price_factor' isn't supposed to be used, why is the value allowed to be entered in the admin?

[Ajeh]

There are 10,000 safeties that "could" be added to Zen Cart ... not all of them have been added, at this time ...

Thanks for the update that this is working for you ...