Instant Search

[carlwhat]

unfortunately i can not/will not debug his code.

marco pm is the one that created this plugin. his code looks to handle this situation although i have not tested.

torvista, on the other hand, while well intentioned, is not a coder. self described as such. so i’m not real sure what he is doing. and i’m reluctant to look.

the error seems pretty obvious to me. the installer is trying to create an index that already exists. and it looks like the file i referenced above handles that situation although i have not tested.

so again i would compare against that version. torvista has forked the original authors repo. and again im not real sure what changes exist.

good luck.

[NWCE]

Thanks again for your reply carlwhat!

I have tried marcopm's plugin from Github as you had suggested...but this code which is intended to recognize and deal with old versions does not allow you to install the plugin.

When all files are uploaded and I go to Admin->Modules->Plugin Mgr, I see the plugin and press the Install key, only to get a white screen and the plugin gets tripped up at DoInstall.

The Debug Error is specifically referencing this code about dealing with past versions.

PHP Fatal error: Declaration of ScriptedInstaller::doUpgrade(string $oldVersion = ''): bool must be compatible with Zencart\PluginSupport\ScriptedInstaller::doUpgrade($oldVersion): ?bool in /home/mysite/public_html/new210/zc_plugins/InstantSearch/v4.0.3/Installer/ScriptedInstaller.php on line 27

When deleting this entire code from line 27 down, and then Installing from Admin-> Plugin Mgr the plugin installs and runs perfectly when tested....no Debug Errors.

Unfortunately this does not fix my error in my original post regarding then running the Database Converter Plugin...it breaks the plugin where it no longer works and when uninstalling and reinstalling the plugin, it will no longer install and I receive the error in my Admin Panel when trying to install....

Duplicate key name 'idx_products_name'
Duplicate key name 'idx_products_description'

When I Search my database....these do not come up in any table....so not sure why this error is occurring.

Any thoughts....as marcopm has not responded in this thread.

I understand that he is likely busy!

[carlwhat]

Thanks again for your reply carlwhat!

I have tried marcopm's plugin from Github as you had suggested...but this code which is intended to recognize and deal with old versions does not allow you to install the plugin.

When all files are uploaded and I go to Admin->Modules->Plugin Mgr, I see the plugin and press the Install key, only to get a white screen and the plugin gets tripped up at DoInstall.

The Debug Error is specifically referencing this code about dealing with past versions.

PHP Fatal error: Declaration of ScriptedInstaller::doUpgrade(string $oldVersion = ''): bool must be compatible with Zencart\PluginSupport\ScriptedInstaller::doUpgrade($oldVersion): ?bool in /home/mysite/public_html/new210/zc_plugins/InstantSearch/v4.0.3/Installer/ScriptedInstaller.php on line 27

this is a very different error than what you were getting before. one has nothing to do with the other.

it looks like you need to make the following changes:

on lines 27, 65 and 124, you will need to change as fllows:

public function doUpgrade(string $oldVersion = ''): ?bool

public function doInstall(string $oldVersion = ''): ?bool

public function doUninstall(string $oldVersion = ''): ?bool 

all you are doing is adding a question mark to before the term bool. that's all you are doing.

When deleting this entire code from line 27 down, and then Installing from Admin-> Plugin Mgr the plugin installs and runs perfectly when tested....no Debug Errors.

where did you ever get that idea to delete all of that code??

of course if you delete all of the code the installer will run perfectly. tell me to do nothing... i'm real good at that.

Duplicate key name 'idx_products_name'
Duplicate key name 'idx_products_description'

When I Search my database....these do not come up in any table....so not sure why this error is occurring.

I understand that he is likely busy!

why someone responds or does not respond, i try not to get too involved in it. i'm also quite busy...

that said, these are keys. they are not in a database table. they are a part of the database table. they are indexes onto the database table.

if the changes i made above do not work, you can try running the following mysql commands.

drop index idx_products_name on products_description;
drop index idx_products_description on products_description;

these can be done on the mysql command line, using a tool like phpmyadmin or my least favorite, install sql patches on the backend of your zc admin page under tools menu. the above mysql statements will need to use a prefix for the products_description table name. if you do not know what i am talking about... well perhaps someone else can help you out.

after you drop the indexes, you can then run the installer again. but it definitely looks like you will need those 3 question marks i referenced above.

let us know how it goes.

[torvista]

This plugin needs a reworking, as indicated here:

https://github.com/marco-pm/zencart_...tsearch/issues

Meanwhile I've been going round in circles to minimise the changes necessary for it to install and function.

This fork works on a new install of Zen Cart:

https://github.com/torvista/zencart_...orvista_fixes/

Changes are in the commit history.

[NWCE]

Thanks carlwhat for your support and help with the error I am getting with this.

I made these 3 code changes to ScriptedInstaller.php and had Uninstalled the plugin.

When I try to Install the plugin with this new ScriptedInstaller.php file I get a white screen with the following Debug Log:

PHP Fatal error: Declaration of ScriptedInstaller::doUpgrade(string $oldVersion = ''): ?bool must be compatible with Zencart\PluginSupport\ScriptedInstaller::doUpgrade($oldVersion): ?bool in /home/mysite/public_html/new210/zc_plugins/InstantSearch/v4.0.3/Installer/ScriptedInstaller.php on line 27

Thoughts on this error??

Thanks again!

[NWCE]

This plugin needs a reworking, as indicated here:

https://github.com/marco-pm/zencart_...tsearch/issues

Meanwhile I've been going round in circles to minimise the changes necessary for it to install and function.

This fork works on a new install of Zen Cart:

https://github.com/torvista/zencart_...orvista_fixes/

Changes are in the commit history.

Thanks for your help with this plugin and your efforts to update the plugin to get it working in this latest Zen Cart version!

[marcopm]

Sorry for not replying to this thread in a while, unfortunately I've been quite busy these past few months. Thanks torvista and carlwhat for your help!
A plugin update has been on my to-do list for a while now, to make it compatible with the latest ZC and PHP versions, and with bugfixes and improvements.
I'll try to do it within the next few weeks, but it may take a while longer unfortunately.

[NWCE]

Thanks for your reply marcopm....and for your offer to update the plugin over time!

I will watch for a newer version!

[DaxtheMan]

ZC 2.1 PHP 8.3

Instant Search works in 2.1 and I am very happy with result with one exception. I have tailored the configuration field to prioritise category but have many duplicate categories - so Instant Search reports each instance as, indeed, it should. However, this does look a little clumsy. Is there any way to avoid duplicated categories appearing in the results? Can't see a toggle in admin that would do it, so it may just not be possible.

Thanks for any help that could be offered.