message stack - when to use add and add_session?

[kamion]

Dear experts,

I'm a noob. But when should one use the add_session method and when should one use the add method in the messageStack class?

Also, can someone review the messageStack usage in all the payment modules? Most of the payment modules contain lots of messageStack usage code like:

$messageStack->add_session(MODULE_PAYMENT_PAYPALDP_TEXT_REFUND_FULL_CONFIRM_ERROR, 'error');

Surely, it's missing the '$class' field in the method parameters?


Cheers,
kamion

[DrByte]

1. add is used when the message doesn't need to be stored in the session.
add_session is when the message needs to be stored in the session, such as when a page-refresh/reload is about to be triggered

2. the admin calls to $messageStack don't need the $class parameter, in fact it will break if you use one. And the example you quoted is for code that only runs in admin mode.

[kamion]

Ok. Thanks for the explanation, DrByte. :)