What is wrong with my form code? (Error)

[sophie666]

Hi everyone, I am doing a custom form for my Zen Cart. Can anyone tell me whats wrong with it?

I put both of them in my public_html/store directory. If you have any suggestions please be super clear since I am really new to this, thanks!

Here is my contactform.htm file:

<form name="contactform" method="post" action="send_form_email.php">
<table width="450px">
<tr>
 <td valign="top">
  <label for="first_name">Name *</label>
 </td>
 <td valign="top">
  <input  type="text" name="name" maxlength="50" size="50">
 </td>
</tr>
<tr>
 <td valign="top">
  <label for="email">Email Address *</label>
 </td>
 <td valign="top">
  <input  type="text" name="email" maxlength="80" size="50">
 </td>
</tr>
<tr>
 <td valign="top"">
  <label for="products">Products(s) *</label>
 </td>
 <td valign="top">
  <input  type="text" name="products maxlength="100" size="50">
 </td>
</tr>

<tr>
 <td valign="top">
  <label for="Location">Location *</label>
 </td>
 <td valign="top">
  <input  type="text" name="location" maxlength="60" size="50">
 </td>
</tr>
<tr>
 <td valign="top">
  <label for="comments">Special Comments/ Instructions </label>
 </td>
 <td valign="top">
  <textarea  name="comments" maxlength="1000" cols="39" rows="6">

Here is my send_form_email.php file:

<?php
if(isset($_POST['email'])) {
     
    // EDIT THE 2 LINES BELOW AS REQUIRED
    $email_to = "[email protected]";
    $email_subject = "Quote Requested";
     
     
    function died($error) {
        // your error code can go here
        echo "We are very sorry, but there were error(s) found with the form you submitted. ";
        echo "These errors appear below.<br /><br />";
        echo $error."<br /><br />";
        echo "Please go back and fix these errors.<br /><br />";
        die();
    }
     
    // validation expected data exists
    if(!isset($_POST['name']) ||
        !isset($_POST['email']) ||
        !isset($_POST['products']) ||
        !isset($_POST['location']) ||
        !isset($_POST['comments'])) {
        died('We are sorry, but there appears to be a problem with the form you submitted.');       
    }
     
    $first_name = $_POST['name']; // required
    $last_name = $_POST['email']; // required
    $email_from = $_POST['products']; // not required
    $telephone = $_POST['location']; // required
    $comments = $_POST['comments']; // not required
     
    $error_message = "";
    $email_exp = '/^[A-Za-z0-9._%-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/';
  if(!preg_match($email_exp,$email_from)) {
    $error_message .= 'The Email Address you entered does not appear to be valid.<br />';
  }
    $string_exp = "/^[A-Za-z .'-]+$/";
  if(!preg_match($string_exp,$name)) {
    $error_message .= 'Please enter your Name.<br />';
  }
  if(!preg_match($string_exp,$products)) {
    $error_message .= 'Please enter the products you would like a quote for.<br />';
  }
  if(strlen($comments) < 2) {
    $error_message .= 'The Comments you entered do not appear to be valid.<br />';
  }
  if(strlen($error_message) > 0) {
    died($error_message);
  }
    $email_message = "Form details below.\n\n";
     
    function clean_string($string) {
      $bad = array("content-type","bcc:","to:","cc:","href");
      return str_replace($bad,"",$string);
    }
     
    $email_message .= "Name: ".clean_string($name)."\n";
    $email_message .= "Email: ".clean_string($email)."\n";
    $email_message .= "Products: ".clean_string($products)."\n";
    $email_message .= "Location: ".clean_string($location)."\n";
    $email_message .= "Comments: ".clean_string($comments)."\n";
     
     
// create email headers
$headers = 'From: '.$email_from."\r\n".
'Reply-To: '.$email_from."\r\n" .
'X-Mailer: PHP/' . phpversion();
@mail($email_to, $email_subject, $email_message, $headers);  
?>
 
<!-- include your own success html here -->
 
Thank you for contacting us! We will be in touch with you very soon!
 
<?php
}
?>

[stevesh]

A link to the site in question would help.

[sophie666]

Here is the link I am currently testing it on my about page:

http://betterdecoratingbible.com/sto...in_page=page_2

[balihr]

<input type="text" name="products maxlength="100" size="50">
</td>

Missing quotation? Let's start there...

[sophie666]

OK thanks for replying. I'm still getting the error though, any other suggestions?

[sophie666]

I am now getting the following error:

We are very sorry, but there were error(s) found with the form you submitted. These errors appear below.

The Email Address you entered does not appear to be valid.
Please enter your Name.
Please enter the products you would like a quote for.
The Comments you entered do not appear to be valid.


Please go back and fix these errors.

what am i doing wrong?