Updating Mod for 150 - Little Problem

[DivaVocals]

That's kind of what I thought it was saying also...but then I thought...why would it say that? This is an addon file that would go in custom templates (vs a core file that the addon modified).

So no, it doesn't exist because when I installed, I installed it into my custom template folder, per the folder structure in the addon's fileset.

It seems strange to me that an addon would be written to look in template_default rather than in custom_template. But that does appear to be what the error is indicating. A simple and obvious fix is to simply load that file into template_default, but I think the better thing to do is to make sure the code is properly written because putting an addon file in template_default instead of custom_template is incorrect procedure unless you want the addon to work in ALL templates vs. your chosen template.

However....this was not an issue in the vanilla install. It's only happening in my customized store. Not sure what's causing this issue.

First thing to do IMHO is to add the file to the default_template folder and see if the error goes away..

I do not think it's an issue for this file to be in the default_template folder.. It's not a core file and will not be overwritten in an upgrade because of this. (which is the primary purpose of the override system)

However, I'll leave it to those more knowledgeable than I to weigh in here..

[ScriptJunkie]

First thing to do IMHO is to add the file to the default_template folder and see if the error goes away..

I do not think it's an issue for this file to be in the default_template folder.. It's not a core file and will not be overwritten in an upgrade because of this. (which is the primary purpose of the override system)

However, I'll leave it to those more knowledgeable than I to weigh in here..

OMG I had the same thought as you, but before I did it, I checked the custom template folder and the file in question simply wasn't there - that's what was causing the error. I have no idea how that happened because I specifically remember uploading that file along with my customized tpl_product_info_display.php file.

So I uploaded it, and now I get this error:

PHP Parse error: syntax error, unexpected T_ELSE in /includes/modules/recent_products.php on line 57

The code for that file, lines 52 - 58 is

$num_products_count = ($recent_products_query == '') ? 0 : $recent_products->RecordCount();
  // show only when 1 or more
 if ($num_products_count > 0) 
  if ($num_products_count < SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS || SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS == 0) 
    $col_width = floor(100/$num_products_count);
  } else {
    $col_width = floor(100/SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS); 

I just don't understand why these legitimate code errors didn't show up during testing on a vanilla install. If the code is wrong - it's wrong - regardless of which template is being used.

Is that right?

[DrByte]

Yes, the code you quoted is wrong ... regardless of what template is being used.

[ScriptJunkie]

Wondering if I need a bracket after this line:

if ($num_products_count < SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS || SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS == 0) 
    $col_width = floor(100/$num_products_count); 

so that it looks like this:

$num_products_count = ($recent_products_query == '') ? 0 : $recent_products->RecordCount();
  // show only when 1 or more
 if ($num_products_count > 0) 
  if ($num_products_count < SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS || SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS == 0) 
    $col_width = floor(100/$num_products_count); {
  } else {
    $col_width = floor(100/SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS); 

[ScriptJunkie]

that didn't work.

[DrByte]

The semicolon is closing the two IF statements.

If you want to nest IF statements, and incorporate ELSE statements also, then you'd be better off using full brace structure.

if (condition) 
{
  if (condition) 
  {
    statement;
  } else {
    statement;
  }
}

[ScriptJunkie]

The semicolon is closing the two IF statements.

If you want to nest IF statements, and incorporate ELSE statements also, then you'd be better off using full brace structure.

if (condition) 
{
  if (condition) 
  {
    statement;
  } else {
    statement;
  }
}

Ahhh ok...so this:

$num_products_count = ($recent_products_query == '') ? 0 : $recent_products->RecordCount();
  // show only when 1 or more
 if ($num_products_count > 0) 
  if ($num_products_count < SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS || SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS == 0) 
    $col_width = floor(100/$num_products_count);
  } else {
    $col_width = floor(100/SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS); 

becomes this?

$num_products_count = ($recent_products_query == '') ? 0 : $recent_products->RecordCount();
  // show only when 1 or more
  if ($num_products_count > 0)
{  
  if ($num_products_count < SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS || SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS == 0)
{  
    $col_width = floor(100/$num_products_count);
  } else {
    $col_width = floor(100/SHOW_PRODUCT_INFO_COLUMNS_RECENT_PRODUCTS);
 }
} 

Edit: Ok, I tried the above but I must have done something wrong, because I'm still getting this error:

PHP Parse error: syntax error, unexpected T_ELSE in /includes/modules/recent_products.php on line 57