I agree, and on a related topic I'm also a BIG proponent of not hardcoding what should be properly included in an admin settings menu. (on/off, yes/no settings should be in the admin menu NOT in the code) Just went through this exercise in collaborating on an update to the Events Calendar module..
That said, there are places where requiring a code edit/merge is simply unavoidable, and in that case I make sure that the changes are CLEARLY commented because it makes it easy as pie to spot changes when using file merging software.. I learned this from developers I've worked with in the past, and several Zen Cart masters employ the same techniques in their code -- Conor Kerr's code is a GREAT example of this.. The way he comments his code changes it's like practically shining a SPOTLIGHT on where the modifications are..
I agree.. though in the defense of some modules (Zen Lightbox for example), I do believe that some of these leftover practices were from the days before the current template stucture became part of the core, and some devs didn't "fix" these hardcoded kinds of things..
Yep.. I totally agree..![]()




Reply With Quote
