Being in NZ, direct bank deposit accounts for about 50% of my sales, and have noticed two problems with it I would like some advice on before I just change it.
1/ There are no reference instructions shown, so it is hard to match payments with orders.
I believe that if I add the last line here that will add it to the email (but I haven't tested it yet because of issue 2)
Code:
define('MODULE_PAYMENT_DIRBANKNZ_TEXT_EMAIL_FOOTER', 
  "Please use the following details to transfer your total order value:\n\n" .
  "\nAccount No.:   " . MODULE_PAYMENT_DIRBANKNZ_ACCNUM .
//  "\nRouting Number:" . MODULE_PAYMENT_DIRBANKNZ_ROUTING . 
  "\nAccount Name:  " . MODULE_PAYMENT_DIRBANKNZ_ACCNAM . 
  "\nBank Name:     " . MODULE_PAYMENT_DIRBANKNZ_BANKNAM .
  "\nReference:     ".$zf_insert_id .
From my research it seems the order number cannot be added to the checkout_confirmation page as it does not exist yet, and while people have suggested workarounds of getting the last order and adding one, that is an approximation that will fail at some point.

2/ Probably more significant, I had an issue a little while back where someone just deposited money into my account with no details and no order! It could be a worse problem, but there was nothing I could do other than wait until someone complained that they didn't get their order and then sort it out. Less than ideal. I was confused about how they had got my bank details without an order, and then it came to me - the customer followed the process to checkout_confirmation, got the bank details, made the deposit and then exited the process, leaving me with no information on the "order" they thought they made.

These two issues suggest to me that the best solution is to have the following process: checkout_confirmation page shows a message like "you have chosen bank deposit, the account details will be shown once your order is confirmed"
checkout_success shows the account details along with the order number.

Does this make sense or have I missed something important (happens a lot)

Oh, and thanks to everyone for their work on making this the rest of zencart, it quite simply makes the impossible possible!

Thanks for your advice.
Pat