Direct Bank Deposit

[DrByte]

1.5.7b PHP 7.3.25 MySQL 5.7.32
OPC
Edit Orders
PayPal Express
Zone Shipping
No other Payment or Shipping Mods Installed

Using dirbanknz.php

Warning log

[05-Jan-2021 13:36:10 US/Central] Request URI: /******/index.php?cmd=orders&page=1&oID=1596&action=update_order&language=NZ, IP address: 122.##.###.###
#1 dirbanknz->update_status() called at [/includes/modules/payment/dirbanknz.php:41]
#2 dirbanknz->__construct() called at [/******/orders.php:266]
#3 require(/******/orders.php) called at [/******/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbanknz.php on line 50.

Latest code from download of file

// class methods    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKNZ_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKNZ_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }

Assuming the item in red is the problem but not sure of the solution.

2 tips:
1. If this store is using this module for "all addresses", eg no zone restrictions, you could just put "return;" as the first line of the update_status() function and skip that part altogether.
2. The parameters passed to the zone lookup query in many older shipping/payment modules' update_status() functions are quite possibly incorrect. Compare with the update_status() function in current built-in shipping/payment modules to see what may be incorrect. It's also easy to test whether the change you make has any undesired side-effects: just test whether the module works both with and without zone restrictions applied for a given address.

[4tinak]

Please help I need the following corrected - see image


Reference - can this be changed to only show the order #?
How do you change MODULE_PAYMENT_DIRBANKAUS_ADDRESS - looks like something is missing.
Can Swift Code be removed?

Thanks for the help!

[rlexyd]

Hi,
Not sure if anyone is monitoring this thread but I'm having an error show after installing direct bank deposit.
I have ZC v1.5.7c and PHP 7.4.21.
I only have the FLAT rate option available to choose from for shipping.
Can anyone help me figure out why and how to fix?
On another note, would anyone also know how to replace (swift code details) to (PayID details) instead?
Thank you.

[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.#1  include(/home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php) called at [/home2//public_html/.com.au/admin/modules.php:200]#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_ADDRESS - assumed 'MODULE_SHIPPING_STOREPICKUP_ADDRESS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php on line 28.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  include(/home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php) called at [/home2//public_html/.com.au/admin/modules.php:200]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_ADDRESS - assumed 'MODULE_SHIPPING_STOREPICKUP_ADDRESS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/languages/english/modules/shipping/storepickup.php on line 30.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_SORT_ORDER - assumed 'MODULE_SHIPPING_STOREPICKUP_SORT_ORDER' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 55.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_TAX_CLASS - assumed 'MODULE_SHIPPING_STOREPICKUP_TAX_CLASS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 57.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_TAX_BASIS - assumed 'MODULE_SHIPPING_STOREPICKUP_TAX_BASIS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 58.


[13-Jul-2021 20:57:20 Australia/Sydney] Request URI: /admin/index.php?cmd=modules&set=shipping, IP address: 101.
#1  storepickup->__construct() called at [/home2//public_html/.com.au/admin/modules.php:204]
#2  require(/home2//public_html/.com.au/admin/modules.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Use of undefined constant MODULE_SHIPPING_STOREPICKUP_STATUS - assumed 'MODULE_SHIPPING_STOREPICKUP_STATUS' (this will throw an Error in a future version of PHP) in /home2//public_html/.com.au/includes/modules/shipping/storepickup.php on line 60.

[rlexyd]

Does the above error mean the "storepickup.php" in this plugin doesn't blend smoothly with the newer 1.5.7c version on php 7.4.21?
I've looked into both files and not sure exactly if all the changes in this plugin's storepickup.php file are all relevant, which might be causing my above errors?
Are the only parts that need to be merged over to the new 1.5.7c storepickup.php file are the 2 text email footer additions??

    $this->email_footer = MODULE_SHIPPING_STOREPICKUP_TEXT_EMAIL_FOOTER;


    function confirmation() {
      return array('title' => MODULE_SHIPPING_STOREPICKUP_TEXT_EMAIL_FOOTER);
    }

[rlexyd]

I'm now getting this error..

[23-Jul-2021 13:15:54 Australia/Sydney] Request URI: /admin/index.php?cmd=orders&origin=index&page=1&oID=20&action=update_order&language=en, IP address: 60.

#1  dirbankaus->update_status() called at [/home2//public_html/.com.au/includes/modules/payment/dirbankaus.php:41]
#2  dirbankaus->__construct() called at [/home2//public_html/.com.au/admin/orders.php:521]
#3  require(/home2//public_html/.com.au/admin/orders.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /home2//public_html/.com.au/includes/modules/payment/dirbankaus.php on line 50.

I looked in that folder on line 50 and line 100 and here are the line codes from those:

$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

function after_order_create($order_id) {      $this->email_footer = sprintf(MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER, $order_id);
    }

[mc12345678]

I'm now getting this error..

[23-Jul-2021 13:15:54 Australia/Sydney] Request URI: /admin/index.php?cmd=orders&origin=index&page=1&oID=20&action=update_order&language=en, IP address: 60.

#1  dirbankaus->update_status() called at [/home2//public_html/.com.au/includes/modules/payment/dirbankaus.php:41]
#2  dirbankaus->__construct() called at [/home2//public_html/.com.au/admin/orders.php:521]
#3  require(/home2//public_html/.com.au/admin/orders.php) called at [/home2//public_html/.com.au/admin/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /home2//public_html/.com.au/includes/modules/payment/dirbankaus.php on line 50.

I looked in that folder on line 50 and line 100 and here are the line codes from those:

$check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

function after_order_create($order_id) {      $this->email_footer = sprintf(MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER, $order_id);
    }

I don't really see how/where line 100 came into concern, but what is being indicated is that at the point of attempting to identify the zone applicable to delivery of the item, it appears that there is no 'id' assigned to the delivery country. Perhaps was this a virtual product or download? May need to "work" around the operation in that area if so in some way to satisfy the intent of collecting the information...

[rlexyd]

Hi mc,
Thank you for your assistance.
I sometimes notice my php files get spaced out between each line, so just to be sure I put line 50 and 100 just incase this was spaced out with the error as well.

As for the item, it's a physical product.

The error log seems to generate everytime I click to go into an order details in admin, whether just going in or updating the status of the order etc..