Assorted Wine Crates

[mr_lunch]

(Forgive me if there's already a thread for this contribution -- I couldn't find it with a search)

I've recently had the need to limit shipping to boxes of 6 or 12 items. Fortunately there's a contrib by georgfly for exactly this purpose. However, I did find a bug and thought I'd post a solution here for anyone else needing it. I'm currently testing it on ZC 1.5.0 -- looking good so far.

At the end of the classes/observers/class.weinkartons_amount.php file, in the case statement there is the following:

case 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING':
case 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT':
case 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION':
    if ($prodincase > 0 && $bigcase > 0) {
        if($prodincase % $bigcase != 0 && $_SESSION['cart']->count_contents() != $smallcase) {
            zen_redirect(zen_href_link(FILENAME_SHOPPING_CART));
        }
    } 

However, at this stage of the switch $prodincase hasn't been declared, so checkout pages were not redirecting if there was a conflict. I've replaced the above with this:

case 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING':
case 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT':
case 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION':
    if($_SESSION['cart']->count_contents() % $bigcase !=0 && $_SESSION['cart']->count_contents() % $smallcase !=0){
        zen_redirect(zen_href_link(FILENAME_SHOPPING_CART));
    } 

A big thanks to georgfly for providing the contrib in the first place.

[schoolboy]

Could you point me to the download of this add-on pls...

I wrote my own module for wine boxes some years ago (but it was clunky) and would like to see this one.

[mr_lunch]

Current download location is http://www.zen-cart.com/downloads.php?do=file&id=1309 listed under the Product Types category.

I think I just found another bug. Around line 62 of the original file is:

        if ($prodincase > 0 && $bigcase > 0) {
          if($prodincase % $bigcase != 0 && $prodincase != $smallcase) {
            $_SESSION['valid_to_checkout'] = false;
            $messageStack->add('shopping_cart', sprintf(TEXT_ORDER_UNDER_MIN_AMOUNT, $bigcase, $smallcase) . '<br />', 'caution');
          }
        } 

Which I've changed to:

        $morethanbigcase = $prodincase % $bigcase;
        if ($prodincase > 0 && $bigcase > 0) {
          if($morethanbigcase != 0 && $morethanbigcase != $smallcase) {
            $_SESSION['valid_to_checkout'] = false;
            $messageStack->add('shopping_cart', sprintf(TEXT_ORDER_UNDER_MIN_AMOUNT, $bigcase, $smallcase) . '<br />', 'caution');
          }
        } 

[schoolboy]

Thanks a ton for the heads-up, and for your revisions. Much appreciated...

[georgfly]

Thanks for your bug-fixes. The first one must indeed be a bug (i have modified this code slightly before i used it in my own shop, and 'accidently' gotten rid of it without ever realizing it...).
For the second one, I guess it depends on what you need. My intention was to either allow customer to purchase a single case with 6 bottles, OR only multiples of 12 (I would not allow to purchase one case of 12 and one case of 6 in the same order). I havent tested it, but I seems you also want to allow mixed orders (multiples of 12 AND a single case of 6). Anyway, thanks for the fixes.

[mr_lunch]

No worries. Actually I found another bug, but was too busy to post a fix. From memory it was that the code after:

      case 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING':
      case 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT':
      case 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION': 

...wasn't taking into consideration that there might be non-wine category items in the cart. Basically, we have to count everything again. So I've incorporated the following (from around line 69 in the original file):

      case 'NOTIFY_HEADER_START_CHECKOUT_SHIPPING':
      case 'NOTIFY_HEADER_START_CHECKOUT_PAYMENT':
      case 'NOTIFY_HEADER_START_CHECKOUT_CONFIRMATION':
      // COUNT ALL WINE-CASE ITEMS IN CART
      $prodincase = 0;
      $mycart = $_SESSION['cart'];
      $myprodids = $mycart->get_product_id_list();
      $myprodids = explode(', ', $myprodids);
      foreach($myprodids as $myprodid) {
        $myprodpaths = zen_get_product_path($myprodid);
        $myprodpaths = explode('_', $myprodpaths);
        $iswine = false;
        foreach($myprodpaths as $myprodpath){
          foreach($winecats as $winecat){
            if ($winecat == $myprodpath){
              $iswine = true;
            }
          }
        }
          if ($iswine){
          $prodincase = $prodincase + $mycart->get_quantity($myprodid);
          }
      }

        $morethanbigcase = $prodincase % $bigcase;
          
        if ($prodincase > 0 && $bigcase > 0) {
          if($morethanbigcase != 0 && $morethanbigcase != $smallcase) {
            zen_redirect(zen_href_link(FILENAME_SHOPPING_CART));
          }
        }
        break;
      default:
        break;
    }
  }
}
?> 

[DeeL]

Does anyone know where I can download this for 1.5? I tried installing the version here http://www.zen-cart.com/downloads.php?do=file&id=1309 but when I tried to login I got a white screen so just reverted. Oh, maybe the fixes above will help? Appreciate your input and I will try the above things.

I am also looking to use it for a pack with either 10, 18, 20, 26 or 28 items. Could someone point me as to what I would need to amend and where to have this mod work do this?

[mr_lunch]

It's been months since I looked at this, but you'd want to look for anywhere $bigcase and $smallcase is mentioned in the observer class. Probably worth replacing those with an array for your needs.

[DeeL]

Sorry, this is relatively new to me so what would I need to enter to define an array? The pack sizes I need are 10, 18, 20, 26 and 28. Do you know if it is possible to set a price for each of those pack sizes?

[DeeL]

How do I define an array?