NAB Transact orders not appearing in admin since move to new server

[DrByte]

While I can't speak for your overall code changes, I can tell you that the following is unnecessarily complex:

(ENABLE_SSL ? 'SSL' : 'NONSSL')

The very purpose of that particular parameter is to take an "SSL" or "NONSSL" parameter and then check against the ENABLE_SSL status and use SSL if it's enabled. So in your case, simply passing 'SSL' in that parameter position would accomplish the same thing you seem to have been targeting.

[jenpen]

Yep, that worked, thanks.
No, I didn't update or anything, just moved all the files from one server to another.
BUT, and here's a clue I think, the SSL on the new server wasn't activated until a day after the move. I knew this and changed the SSL to "false" in the two configure files (and had the cart "down for maintenance") until the SSL kicked in, but maybe the NAB module picked up that there was no SSL? You'll see in my post above that I suspected it had something to do with that line of code.

[i2ts]

While I can't speak for your overall code changes, I can tell you that the following is unnecessarily complex:

(ENABLE_SSL ? 'SSL' : 'NONSSL')

The very purpose of that particular parameter is to take an "SSL" or "NONSSL" parameter and then check against the ENABLE_SSL status and use SSL if it's enabled. So in your case, simply passing 'SSL' in that parameter position would accomplish the same thing you seem to have been targeting.

Are you suggesting the lines should be as below?

$gateway_vars['return_link_url'] = zen_href_link(FILENAME_CHECKOUT_SUCCESS, '', 'SSL', true);
$gateway_vars['reply_link_url'] = zen_href_link(FILENAME_CHECKOUT_PROCESS, $query_string,  'SSL' ); 

I am checking in SSL is enabled on purpose. Hence

(ENABLE_SSL ? 'SSL' : 'NONSSL') 

As NAB Transact provides the SSL payment page where the customers enter the card details I have seen carts who haven't got their own SSL. While I don't recommend anyone collecting personal information (even if they are not credit card details) via a non-SSL page it is possible for business owners to do this. This is the reason I am checking if SSL is enabled. If it is the code will pass the SSL enabled URL, if it's not the code will pass the non-SSL URL.

In fact, I should have had this code from day one.

The fact Zen Cart ignore if a non-SSL URL is called back has nothing to do with the module or NAB Transact. As I pointed out the code in init_session.php is doing this. Not sure if it's by design. If it is, it is strange ZC allows the cart to operate without SSL, but forces SSL at a certain point. Why not enforce the fact cart must have SSL everywhere? I digress.

I didn't want to code the module specific to this anomaly. The code I gave will work if init_session.php is fixed and ZC starts supporting non-SSL callback (fixed is probably not the correct term as I don't know if it's by design or a mistake)

Want to hear your thoughts on this.

[DrByte]

Not sure if it's by design. If it is, it is strange ZC allows the cart to operate without SSL, but forces SSL at a certain point. Why not enforce the fact cart must have SSL everywhere? I digress.

Well .. not "everything" needs to be SSL. Do all the "product" and product-listing pages need to be SSL? Why?

As far as checkout, Zen Cart does already pass the 'SSL' parameter for all checkout and my-account, etc pages. Same with built-in payment modules.
3rd-party module writers need to also embrace that programming convention, especially those who cannot allow for payment on-site and must rely on passing things back and forth with callbacks etc.

[i2ts]

Well .. not "everything" needs to be SSL. Do all the "product" and product-listing pages need to be SSL? Why?

I should have been more specific I was refering to the checkout process . I agree, the catalogue doesn't need SSL.

As far as checkout, Zen Cart does already pass the 'SSL' parameter for all checkout and my-account, etc pages.

As far as I know ZC doesn't force the shopping cart owners to have SSL for checkout process. I have test installation of ZC running on local my servers without SSL. Am I missing something?

[DrByte]

Of course Zen Cart can't "force" anybody to do anything. It can't force you to eat your green vegetables each day either.

But, if the storeowner enables SSL on their hosting account and then tells Zen Cart to enable SSL and gives the SSL URL, then Zen Cart will use that SSL info when it builds every page/form that ought to be protected by SSL, such as checkout, login, myAccount, admin, etc. As far as core code is concerned anyway.
Third-party addons which don't specify that a particular URL needs to be SSL, as I described in my earlier posts, won't benefit from that automatic use of SSL.

[i2ts]

After checking the implementation of the zen_href_link() function I get your orignal point. If I simply pass the value 'SSL' for the $connection parameter the function will check if SSL is enabled and construct the URL. Hence (ENABLE_SSL ? 'SSL' : 'NONSSL') is redundant in my code.

$gateway_vars['return_link_url'] = zen_href_link(FILENAME_CHECKOUT_SUCCESS, '', 'SSL', true);
$gateway_vars['reply_link_url'] = zen_href_link(FILENAME_CHECKOUT_PROCESS, $query_string,  'SSL' ); 

is more efficient

[marmi01]

I too am having this issue but it's intermittent.

Most of the time it works ok but on a couple of occasions it fails and no order is generated.

Mick

[i2ts]

Have you tried the above mentioned code changes?

[marmi01]

I'll try it when I get a chance.

Mick