Edit Orders v4.0 Support Thread

[lhungil]

... I noticed the totals prior to the editing of order were way off, but tested it anyway to see what it would do. ...

Older versions of Edit Orders (< 4.1) allowed the store owner to manually modify almost the entire order (including order total lines). It was not uncommon to find problems with math (as these needed to be done by the person editing the order) in stores using older versions of Edit Orders. If you look through the forums there are a number of other posts regarding issues caused by older versions of Edit Orders (including other math related items).


As of Edit Orders 4.1.x, end users are no longer allowed to manually "adjust" the subtotal (and certain other order total lines) within Edit Orders to avoid such issues. And instead of Edit Orders handling any math related to the order total modules, the order total modules are actually run (same as during checkout). This allows the order total modules to do their own calculations based upon the order contents.

As a result, under Edit Orders 4.1.x if the "subtotal" was off before editing, it will be off after editing (it is not recalculated, just loaded from the database as-is and adjusted up / down when products are added / edited / removed).

If you create a new order in the new store, then attempt to edit the order:

• Are the order totals correct when the order is first loaded (no edits)?
• Change the product price and then press "update". Are the order totals correct?
• Add a product to the order and then press "update". Are the order totals correct?

... I then went to the server and found the error message. It is like the 1.3.9h store that is live...only with a different parameter it wishes to have. ...

I'll have to take a look at this. I think I know the cause, but want to verify the fix on a couple test sites.

... When I ran the installer for the upgrade of the database/cfg files I noticed it asked about the UTF8 and checked it off. I noticed that the saved DB said: /*!40101 SET NAMES utf8 */; so took it to mean that was the right thing to do since it appeared the DB was UTF8 too. ...

If the database columns and tables were all set to use a CHARACTER SET of UTF8 previous to the upgrade, you are probably okay (you can check this in phpMyAdmin or similiar). This is rare because out of box Zen Cart < 1.5.0 always used iso-latin-1. When upgrading from Zen Cart < 1.5.0 if the 1.3.x database was iso-latin-1 you still need to manually address this (different store configurations need different massaging and conversions - especially multilingual stores, so this was not automated).

... All items in my store --Live and test clone -- are virtual downloads, no shipping required and since it is a test store I did not upload the downloadable zips to the test store. ...

Ahhh, by default Zen Cart does not populate the "shipping" address when an order is completely virtual. If the shipping address contains an address with NO "country" (or a country not found in the Zen Cart database), this would be the cause of the message "Warning: One or more of the customer address fields contains a country name unknown to Zen Cart ("Locations / Taxes"->"Countries"). Taxes and some shipping modules may not function correctly until the issue has been resolved."

If all of the products are indeed virtual (and shipping will NEVER be used), you can disable the warning by making the following change in "/admin/edit_orders.php":

    	if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
    		!is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) /*||
    		!is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])*/) {
    		$messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
    	}

NOTE: Also make sure you apply all known bugfixes for Edit Orders 4.1.4. Some examples (there may be others, but these two come to mind): bugfix when downloadable products are disabled and coupon validation functions are missing from the Zen Cart admin.

[DarkAngel]

Older versions of Edit Orders (< 4.1) allowed the store owner to manually modify almost the entire order (including order total lines). It was not uncommon to find problems with math (as these needed to be done by the person editing the order) in stores using older versions of Edit Orders. If you look through the forums there are a number of other posts regarding issues caused by older versions of Edit Orders (including other math related items).


As of Edit Orders 4.1.x, end users are no longer allowed to manually "adjust" the subtotal (and certain other order total lines) within Edit Orders to avoid such issues. And instead of Edit Orders handling any math related to the order total modules, the order total modules are actually run (same as during checkout). This allows the order total modules to do their own calculations based upon the order contents.

As a result, under Edit Orders 4.1.x if the "subtotal" was off before editing, it will be off after editing (it is not recalculated, just loaded from the database as-is and adjusted up / down when products are added / edited / removed).

If you create a new order in the new store, then attempt to edit the order:

• Are the order totals correct when the order is first loaded (no edits)?
• Change the product price and then press "update". Are the order totals correct?
• Add a product to the order and then press "update". Are the order totals correct?

I'll have to take a look at this. I think I know the cause, but want to verify the fix on a couple test sites.



If the database columns and tables were all set to use a CHARACTER SET of UTF8 previous to the upgrade, you are probably okay (you can check this in phpMyAdmin or similiar). This is rare because out of box Zen Cart < 1.5.0 always used iso-latin-1. When upgrading from Zen Cart < 1.5.0 if the 1.3.x database was iso-latin-1 you still need to manually address this (different store configurations need different massaging and conversions - especially multilingual stores, so this was not automated).



Ahhh, by default Zen Cart does not populate the "shipping" address when an order is completely virtual. If the shipping address contains an address with NO "country" (or a country not found in the Zen Cart database), this would be the cause of the message "Warning: One or more of the customer address fields contains a country name unknown to Zen Cart ("Locations / Taxes"->"Countries"). Taxes and some shipping modules may not function correctly until the issue has been resolved."

If all of the products are indeed virtual (and shipping will NEVER be used), you can disable the warning by making the following change in "/admin/edit_orders.php":

        if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
            !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) /*||
            !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])*/) {
            $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
        }

NOTE: Also make sure you apply all known bugfixes for Edit Orders 4.1.4. Some examples (there may be others, but these two come to mind): bugfix when downloadable products are disabled and coupon validation functions are missing from the Zen Cart admin.

OK, I see, yes in the previous version I would enter the item into the order by clicking the buttons to add a product then when going thru that entire process we could then enter the "reason" of addition then enter right beside it the "price" like -3.99. Hitting update would deduct it.

What the edit orders used in my store is for actually are for our contests. When we have winners from our own contests or those we are sponsors in, I go in and add that product to their account.

I never thought about adding the product, in this new version, then manipulating the amount in the upper section then hitting update.

As long as the customers order is correct then it does not matter if there are errors I guess…I can just go periodically into the log folder and delete them.

I just wish it would have stayed the same since that is so much more easier. I just need to be able to edit an order to allow their prize to be added to their downloads vs uploading it to another folder then deleting when they nab it…this way it is in their account should they end up with a computer crash and lose stuff.

I do not have it set as a workable store since it is for testing, therefore, the payment/shipping mods are not working and it is set to be a view with prices showing then most of the sidebar links go to the live store for purchasing. We have no shippable at all everything are .zips for downloading.

I will drop tables then reinstall the live store db again and see if the customer orders are showing right…not in the hundreds of dollars. Then try again to upgrade from 1.3.9h to 1.54…LOL

This is why I am taking my time to do this upgrade thing….otherwise I will just have to stay with 1.3.9h, thank goodness we have only downloadables.

Thanks and while you check out those things you talk about I will take my time with trying again and let you know the progress.

[marton_1]

I have v1.5.1 with the classic template

I installed edit-order about a year ago and it worked fine.

I wanted to change an order today but the "edit" button is not showing up?

I looked in the configuration tab and edit -order is there.

Could I have switched off the edit-order somewhere? Sorry for the dumb question.
I looked for th e"how to use" but don't find that

[marton_1]

I have v1.5.1 with the classic template

I installed edit-order about a year ago and it worked fine.

I wanted to change an order today but the "edit" button is not showing up?

I looked in the configuration tab and edit -order is there.

Could I have switched off the edit-order somewhere? Sorry for the dumb question.
I looked for th e"how to use" but don't find that

I uploaded the edit-order files with ftp and now I have the "edit" button again .

When I click the edit button the edit template shows up OK.
When I edit something and click update I get an error message.
The error log shows

[25-Dec-2015 23:17:37 Europe/Zurich] PHP Fatal error:  1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `products` WHERE `p`.`products_id` = '668' in /home/httpd/vhosts/simmar.ch/httpdocs/catalog/includes/classes/db/mysql/query_factory.php on line 120

The Products_id` = '668' is correct
Is there some way I can force the config.eo_onetime.php to run again? Or is that not a good idea

[marton_1]

This is how Products_id` = '668' row looks in the products table

I had not made any changes to my original files in the 1_modified_core_files section. So I just uploaded the new files from the add-on/plug-in; no merging required :)

[marton_1]

I see when I added a new product to an order that works but th eorder value is not updated

I activated the edit orders log "Trace" and got this
============================================================
= Edit Orders (4.1.4) Action Log
============================================================
Order ID: 1108
Action Requested: edit
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_tax;ot_loworderfee;ot_gv;o t_total

============================================================
= Edit Orders (4.1.4) Action Log
============================================================
Order ID: 1108
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_tax;ot_loworderfee;ot_gv;ot_total

Requested Products:
array (
  250 => 
  array (
    'qty' => '1',
    'name' => 'Den Winter Parka mit Fellkragen',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '2887',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '2896',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '49.90',
  ),
  251 => 
  array (
    'qty' => '2',
    'name' => 'Strickpullover Elch',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '3086',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '3092',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '24.90',
  ),
  252 => 
  array (
    'qty' => '1',
    'name' => 'Strickpullover Elch',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '3086',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '3091',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '24.90',
  ),
  253 => 
  array (
    'qty' => '1',
    'name' => 'Strickpullover Elch',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '3086',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '3096',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '24.90',
  ),
  254 => 
  array (
    'qty' => '2',
    'name' => 'Strickpullover Elch',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '3089',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '3092',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '34.90',
  ),
  255 => 
  array (
    'qty' => '1',
    'name' => 'Den Winter Parka mit Fellkragen',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '2887',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '2896',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '49.90',
  ),
  275 => 
  array (
    'qty' => '1',
    'name' => 'Puppy Angel Down Kapuze und Kustfel Padded Vest, regular OW240',
    'onetime_charges' => '0.0000',
    'attr' => 
    array (
      2 => 
      array (
        'value' => '7911',
        'type' => '2',
      ),
      1 => 
      array (
        'value' => '7915',
        'type' => '2',
      ),
    ),
    'model' => '',
    'tax' => '0',
    'final_price' => '79.90',
  ),
)


============================================================
= Processing Requested Updates to Products
============================================================

============================================================
= Edit Orders (4.1.4) Action Log
============================================================
Order ID: 1108
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_tax;ot_loworderfee;ot_gv;o t_total

With debug Product I get
============================================================
= Edit Orders (4.1.4) Action Log
============================================================
Order ID: 1108
Action Requested: update_order
Enabled Order Totals: ot_subtotal;ot_shipping;ot_coupon;ot_group_pricing;ot_tax;ot_loworderfee;ot_gv;o t_total

   0 => 
      array (
        'option' => 'Grosse',
        'value' => '30cm',
        'option_id' => '2',
        'value_id' => '268',
        'prefix' => '+',
        'price' => '12.0000',
      ),
      1 => 
      array (
        'option' => 'Farbe',
        'value' => 'Fuchsia',
        'option_id' => '1',
        'value_id' => '75',
        'prefix' => '+',
        'price' => '0.0000',
      ),
    ),
  ),
  6 => 
  array (
    'qty' => 1,
    'id' => '1906',
    'name' => 'Puppy Angel Down Kapuze und Kustfel Padded Vest, regular OW240',
    'model' => '',
    'tax' => '0.0000',
    'price' => '79.9000',
    'final_price' => '79.9000',
    'onetime_charges' => '0.0000',
    'products_priced_by_attribute' => '0',
    'product_is_free' => '0',
    'products_discount_type' => '0',
    'products_discount_type_from' => '0',
    'attributes' => 
    array (
      0 => 
      array (
        'option' => 'Grosse',
        'value' => 'ML',
        'option_id' => '2',
        'value_id' => '769',
        'prefix' => '+',
        'price' => '0.0000',
      ),
      1 => 
      array (
        'option' => 'Farbe',
        'value' => 'Grau',
        'option_id' => '1',
        'value_id' => '71',
        'prefix' => '+',
        'price' => '0.0000',
      ),
    ),
  ),
)

Order Product ID: 250 Row ID: 0
Product in Request: 
array (
  'qty' => 1,
  'name' => 'Den Winter Parka mit Fellkragen',
  'onetime_charges' => '0.0000',
  'attr' => 
  array (
    2 => 
    array (
      'value' => '2890',
      'type' => '2',
    ),
    1 => 
    array (
      'value' => '2896',
      'type' => '2',
    ),
  ),
  'model' => '',
  'tax' => '0',
  'final_price' => '49.90',
)

Old Product:
array (
  'qty' => 1,
  'id' => '668',
  'name' => 'Den Winter Parka mit Fellkragen',
  'model' => '',
  'tax' => '0.0000',
  'price' => '37.9000',
  'final_price' => '49.9000',
  'onetime_charges' => '0.0000',
  'products_priced_by_attribute' => '0',
  'product_is_free' => '0',
  'products_discount_type' => '0',
  'products_discount_type_from' => '0',
  'attributes' => 
  array (
    0 => 
    array (
      'option' => 'Grosse',
      'value' => '30cm',
      'option_id' => '2',
      'value_id' => '268',
      'prefix' => '+',
      'price' => '12.0000',
    ),
    1 => 
    array (
      'option' => 'Farbe',
      'value' => 'Silber',
      'option_id' => '1',
      'value_id' => '31',
      'prefix' => '+',
      'price' => '0.0000',
    ),
  ),
)

Old Order Subtotal: 269.2000
Old Order Totals:
array (
  0 => 
  array (
    'title' => 'Zwischensumme:',
    'text' => 'CHF 269,20',
    'class' => 'ot_subtotal',
  ),
  1 => 
  array (
    'title' => 'Versandkosten:',
    'text' => 'CHF 0,00',
    'class' => 'ot_shipping',
  ),
  2 => 
  array (
    'title' => 'Endsumme:',
    'text' => 'CHF 269,20',
    'class' => 'ot_total',
  ),
)

Old Tax (total): 0.00
Old Tax Groups:
array (
)

[lat9]

I uploaded the edit-order files with ftp and now I have the "edit" button again .

When I click the edit button the edit template shows up OK.
When I edit something and click update I get an error message.
The error log shows

[25-Dec-2015 23:17:37 Europe/Zurich] PHP Fatal error:  1054:Unknown column 'p.products_quantity' in 'field list' :: SELECT `p`.`products_quantity` FROM `products` WHERE `p`.`products_id` = '668' in /home/httpd/vhosts/simmar.ch/httpdocs/catalog/includes/classes/db/mysql/query_factory.php on line 120

The Products_id` = '668' is correct
Is there some way I can force the config.eo_onetime.php to run again? Or is that not a good idea

That's a "known bug". You'll need to edit the file /YOUR_ADMIN/includes/functions/extra_functions/edit_orders_functions.php. Change the line that reads:

'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS .

to

'SELECT `p`.`products_quantity` FROM `' . TABLE_PRODUCTS . '` AS `p`' .

[marton_1]

Thank you very much for your reply, even on Christmas weekend!
Your fix solved the problem that I reported but now I have

"26-Dec-2015 21:21:50 Europe/Zurich] PHP Fatal error:  Call to undefined function zen_product_in_category() in /home/httpd/vhosts/simmar.ch/httpdocs/catalog/admin/includes/functions/extra_functions/edit_orders_functions.php on line 326

Oh dear

I changed the name of my admin folder!!

[mc12345678]

Thank you very much for your reply, even on Christmas weekend!
Your fix solved the problem that I reported but now I have

"26-Dec-2015 21:21:50 Europe/Zurich] PHP Fatal error:  Call to undefined function zen_product_in_category() in /home/httpd/vhosts/simmar.ch/httpdocs/catalog/admin/includes/functions/extra_functions/edit_orders_functions.php on line 326

Oh dear

I changed the name of my admin folder!!

Yeah, but those that have tagged ths thread to follow any of the previus 815 messages possibly received a copy of it. Would recommend changing the actual admin folder path. As for the missing function, sounds like a missing file in the functions directory. Going to do a "local" search first to advise which file(s) to reload to the store.

[mc12345678]

Thank you very much for your reply, even on Christmas weekend!
Your fix solved the problem that I reported but now I have

"26-Dec-2015 21:21:50 Europe/Zurich] PHP Fatal error:  Call to undefined function zen_product_in_category() in /home/httpd/vhosts/simmar.ch/httpdocs/catalog/admin/includes/functions/extra_functions/edit_orders_functions.php on line 326

Oh dear

I changed the name of my admin folder!!

Yeah, looks like there might be something amiss with: includes/functions/functions_categories.php