Edit Orders v4.0 Support Thread

[lat9]

EO 4.1.6 orders.php patches for ZC 1.5.5a

I am upgrading to ZC 1.5.5a from 1.3.9h with all fresh configuration and only migrating the database.

The read me file for EO 4.1.6 under Modified Core files, item 3, states:

There are five (5) change sections that apply to "Edit Orders" and other sections that introduce the Super Orders navigation to the orders' handling. If you are installing/upgrading on Zen Cart 1.5.5 or later, these navigation-related changes are already incorporated, but you'll need to merge the five change-sections into your version of this file.

"

In the 1_modified_core_files folder the orders.php file provided has only 4 change sections clearly marked. These are edit order patches 2 of 5 through to 5 of 5.

Are there really only 4 patches or are there 5?

Bailey

There really are 5 patches; the first (a one-line insert) is at line 331 of the plugin's orders.php to add the edit_orders.css file's load.

[DTomlinson]

I've been using Edit Orders (slightly modified by me) on 1.5.1 forever. Now upgrading to 1.5.5 (as a new install) there are a couple of issues I haven't been able to resolve.

First one is the big one - the tax treatment (we're in Canada) of the order_total items. Most of these are discounts, which should affect the tax charged etc (reducing it).
I also tried a COD charge, which of course is taxable, and determined the totals correct after placing the order.

After Admin / Edit Orders / (no changes) / Update: First update, the total and tax was changed to completely wrong - it didn't add in the COD fee, and the total included only some of the tax. On the second Update, the tax was corrected on the shipping, however the COD fee and the tax on it is completely ignored for the tax amount AND the base COD fee.

I've attached the edit orders debug log.

HOW editing works, and what code is used to recalc these things, or at least the flow - and what dependancies would be great to know so I can edit myself. Can you point me to documentation of who does what to who for these?

Thanks,
Dan Tomlinson

[marton_1]

I've been using Edit Orders (slightly modified by me) on 1.5.1 forever. Now upgrading to 1.5.5 (as a new install) there are a couple of issues I haven't been able to resolve.

First one is the big one - the tax treatment (we're in Canada) of the order_total items. Most of these are discounts, which should affect the tax charged etc (reducing it).
I also tried a COD charge, which of course is taxable, and determined the totals correct after placing the order.

After Admin / Edit Orders / (no changes) / Update: First update, the total and tax was changed to completely wrong - it didn't add in the COD fee, and the total included only some of the tax. On the second Update, the tax was corrected on the shipping, however the COD fee and the tax on it is completely ignored for the tax amount AND the base COD fee.

I've attached the edit orders debug log.

HOW editing works, and what code is used to recalc these things, or at least the flow - and what dependancies would be great to know so I can edit myself. Can you point me to documentation of who does what to who for these?

Thanks,
Dan Tomlinson

I had a similar problem due to the default sort order!
The tax has to be the "lowest" on the list just before the final total!

[DTomlinson]

I had a similar problem due to the default sort order!
The tax has to be the "lowest" on the list just before the final total!

That one I have :) It's some items that are being ignored, no tax changes, or even just dropped

[lat9]

I've been using Edit Orders (slightly modified by me) on 1.5.1 forever. Now upgrading to 1.5.5 (as a new install) there are a couple of issues I haven't been able to resolve.

First one is the big one - the tax treatment (we're in Canada) of the order_total items. Most of these are discounts, which should affect the tax charged etc (reducing it).
I also tried a COD charge, which of course is taxable, and determined the totals correct after placing the order.

After Admin / Edit Orders / (no changes) / Update: First update, the total and tax was changed to completely wrong - it didn't add in the COD fee, and the total included only some of the tax. On the second Update, the tax was corrected on the shipping, however the COD fee and the tax on it is completely ignored for the tax amount AND the base COD fee.

I've attached the edit orders debug log.

HOW editing works, and what code is used to recalc these things, or at least the flow - and what dependancies would be great to know so I can edit myself. Can you point me to documentation of who does what to who for these?

Thanks,
Dan Tomlinson

Dan, how "slightly modified" is your copy of Edit Orders? Are you using the 4.1.6 EO version as your change-basis?

[DTomlinson]

The 4.1.6 EO is installed, and as far as I remember is unchanged.

It's the previous that I'd modified on the live site.


What I modified was to not allow the user to "lose" information. I always kept the original order quantities etc, and had added fields to do that.
All added items were tagged as [CSAdd] in the product name, as well the original quantity was kept. 0 became a valid order quantity that never could ship of course - but a customer, or me, could see the original and as-shipped order.

We have 50,000+ products in 1,000+ categories - and 3 people who deal with orders, so there has to be that level of auditability.

That's not in THIS install - yet! I have to wrap my head around how to change 4.1.6 to have the capability I had in 4.0.3 on ZC151.