/includes/modules/pages/redirect/header_php.php has no notifier hook

[lat9]

The file /includes/modules/pages/redirect/header_php.php does not include a call to $zco_notifier->notify() at its onset, making it impossible to override with an observer class. Suggested correction:

<?php
/**
 * redirect handler 
 *
 * @package page
 * @copyright Copyright 2003-2011 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: header_php.php 19516 2011-09-14 21:27:30Z wilt $
 */
if (!defined('IS_ADMIN_FLAG')) {
  die('Illegal Access');
}
// This should be the first line of the script
$zco_notifier->notify('NOTIFY_HEADER_START_REDIRECT');

switch ($_GET['action']) {

[lat9]

OK, it's more than just the redirect page. The following pages' header_php.php files don't include the start/stop notifiers. I've included all of them for completeness, even though some (like page_2) are pretty trivial:

account_newsletters, advanced_search, conditions, cookie_usage, customers_authorization, discount_coupon, download_timeout, featured_products, gv_redeem, info_shopping_cart, page_2 (and _3 and _4), payer_auth_auth, payer_auth_frame, payer_auth_verifier, popup_* (except for popup_images and popup_images_additional which share the same notifier values), privacy, product_free_shipping_info, product_music_info, products_all, products_new, reviews, shippinginfo, specials and ssl_check

[DrByte]

Thoroughness is one thing. Thanks. We'll look into it.

But much more important is understanding what business cases you're encountering where you feel you need to use observers on any of those pages. Can you give scenarios?

[lat9]

No business case, just completeness ...

The only one that I can remotely envision is download_timeout. If I've chosen to hook the notifier and perform some special processing for the download page, I might also be interested that the download timed out.