Stripe.com payment integration module

[OJ_SIMON]

Before I make this update push, I was receiving error messages on the customer side (ZC 2.0.1 / PHP 8.3 / Mod version 2.05) stating that the table "myprefix_stripe" was not available. I ended up finding a table just named "stripe" in my database listing. I renamed that database as necessary and everything worked nominally.

Then noticed the following code:

in \www\includes\modules\payment\stripe.php (both directories)

  $db-> execute("CREATE TABLE stripe(id INT(11) AUTO_INCREMENT PRIMARY KEY,customers_id INT(11),Stripe_Customers_id VARCHAR(32))"); 

Should this code be changed to:

  $db-> execute("CREATE TABLE " . DB_PREFIX  . "stripe(id INT(11) AUTO_INCREMENT PRIMARY KEY,customers_id INT(11),Stripe_Customers_id VARCHAR(32))"); 

Yes - if this is just for your own use,
No - if it is for use by others also.

[OJ_SIMON]

define('TABLE_STRIPE', DB_PREFIX . 'stripe');

$db-> execute("CREATE TABLE " . TABLE_STRIPE  . "(id INT(11) AUTO_INCREMENT PRIMARY KEY,customers_id INT(11),Stripe_Customers_id VARCHAR(32))"); 

the above is how it should be done then anyone can use it without having to change code.

[retched]

define('TABLE_STRIPE', DB_PREFIX . 'stripe');

$db-> execute("CREATE TABLE " . TABLE_STRIPE  . "(id INT(11) AUTO_INCREMENT PRIMARY KEY,customers_id INT(11),Stripe_Customers_id VARCHAR(32))"); 

the above is how it should be done then anyone can use it without having to change code.

Noted. I forgot that the TABLE_ constants are always accessible. Submitting now.

[OJ_SIMON]

can i ask what this upgrade version is fixing or dealing with?

[retched]

can i ask what this upgrade version is fixing or dealing with?

Just a bugfix for configurations that are using table prefixes.

The native code makes a call to a database table named `TABLE_STRIPE` but on the modules installation, it only makes a table named 'stripe' and ignores the prefix configuration. If this module is already working, you don't need to change anything (this means your ZenCart tables do not have prefixes and works fine with the table named just stripe). However, if someone just snags the module from the plugins directory and they do have table prefixes configured, they'll run into errors as the table is wrongly named and referred to incorrectly in the database define.

[OJ_SIMON]

Just a bugfix for configurations that are using table prefixes.

The native code makes a call to a database table named `TABLE_STRIPE` but on the modules installation, it only makes a table named 'stripe' and ignores the prefix configuration. If this module is already working, you don't need to change anything (this means your ZenCart tables do not have prefixes and works fine with the table named just stripe). However, if someone just snags the module from the plugins directory and they do have table prefixes configured, they'll run into errors as the table is wrongly named and referred to incorrectly in the database define.

Seem needed.

can i also ask if you have or could check if the amount sent to Stripe is the correct amount when using the following:
1. a coupon,
2. a product that has a offer price,

I only ask this because in my installation the only amount sent to stripe is the total before any discount is applied?

[retched]

I can check on the first in a few but can you explain the second? What do you mean by "offer price"?