PayPal Website Payments Standard - Problem with product names

[philip937]

I have PayPal Website Payments Standard - IPN enabled.

ZC version 1.3.9h

I have the show item lines in PayPal enabled.

When directed to PayPal, The item titles are showing the Attribute Name and option instead of the Product name??

Is this normal or is something wrong here?

Thanks

Phil

[kobra]

Not sure with IPN
But you should switch to the more robust and stable PayPalExpress module

[philip937]

It's only when there is an attribute assigned. Working otherwise.

Surely it's just calling the wrong info? Or maybe it's calling both and there is a character limit on PayPal?

[kobra]

Enable paypal logging in the admin setup
Make a couple of test purchases and check the logs
Post them here if you need assistance figuring them out

[philip937]

Ok cool will do, I'll have a look at the source code in the confirmation page too, hopefully should see the PayPal HTML form markup on there?

[philip937]

think I have fixed it, though if someone can check the change I have made and let me know if there is any reason this will casue any problems.

In /includes/modules/payment/paypal/paypal_functions.php

I found this code:

      // if there are attributes, loop thru them and add to description
      if (isset($order->products[$i]['attributes']) && sizeof($order->products[$i]['attributes']) > 0 ) {
        $optionsLI["item_name_$k"] = '';
        for ($j=0, $n2=sizeof($order->products[$i]['attributes']); $j<$n2; $j++) {
          $optionsLI["item_name_$k"] .= "\n " . $order->products[$i]['attributes'][$j]['option'] .
                                        ': ' . $order->products[$i]['attributes'][$j]['value'];

        } // end loop
      } // endif attribute-info 

notice how the $optionsLI["item_name_$k"] = ''; is blank and not redefined anywhere after?

so I changed to this:

// if there are attributes, loop thru them and add to description
      if (isset($order->products[$i]['attributes']) && sizeof($order->products[$i]['attributes']) > 0 ) {
       // $optionsLI["item_name_$k"] = '';
          $optionsLI["item_name_$k"] = $order->products[$i]['name'];
        for ($j=0, $n2=sizeof($order->products[$i]['attributes']); $j<$n2; $j++) {
         // $optionsLI["item_name_$k"] .= "\n " . $order->products[$i]['attributes'][$j]['option'] .
          //                              ': ' . $order->products[$i]['attributes'][$j]['value'];
            $optionsLI["item_name_$k"] .= ': ' . $order->products[$i]['attributes'][$j]['value'];

        } // end loop
      } // endif attribute-info 

Look forward to hearing back, cheers

Phil

[DrByte]

Based on what you said you wanted it to differently, yes that should work.

[philip937]

Based on what you said you wanted it to differently, yes that should work.

Doc, so is it normal behaviour that when there are options that it only uses the option name and value as the item title? That's what the original code seems to be doing?

Glad what I've done is ok :)