Product Listing Sorter Drop-Down [Support Thread]

[marton_1]

Does not work in v157 PHP 7.4, I get a deprecated message. I looked in Github but did not see a fix

PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in C:\xampp73a\htdocs\Zencart157b\catalog\includes\modules\mytemplate\dynamic_filter.php on line 14.

I tried replacing

while(list($key, $value) = each ($_GET))

with

while(list($key) = key ($_GET))
	while(list($value) = current ($_GET))

Which exhausted my scanty PHP knowledge and did not fix the problem

[torvista]

...dynamic_filter.php on line 14

This file is not part of product listing sorter.

[carlwhat]

yeah, the support thread for said module is here:

https://www.zen-cart.com/showthread....-Thread/page16

@marton

you can try:

// replace
while(list($key, $value) = each ($_GET))
// with
foreach ($_GET as $key => $value) 

best.

[marton_1]

This file is not part of product listing sorter.

Apologies, I was working on two plugins and got them mixed up

Anyway, I have a real question!

Is anybody using this plugin with 157b and PHP7.4?
I ask because I have some display issues in the product listing and want to check if I screwed up when installing.
Everything else works fine.

[torvista]

As a result of your prompting I'm overhauling this for 157 right now. Yes there are issues.
I should complete it over the weekend...

[marton_1]

yeah, the support thread for said module is here:

https://www.zen-cart.com/showthread....-Thread/page16

@marton

you can try:

// replace
while(list($key, $value) = each ($_GET))
// with
foreach ($_GET as $key => $value) 

best.

Many thanks for your fix which worked fine and was above and beyond the call of duty :)

Next problem in the correct thread.

[marton_1]

Good news but feeling guilty :)

[torvista]

I've updated the Github. Please report issues there.

[marton_1]

I've updated the Github. Please report issues there.

Your installation instructions say "\includes\functions\extra_functions.php - CORE FILE MODIFICATION to function zen_create_sort_heading".

I assume "extra_functions.php" is a typo and you mean "functions_general.php" which is the only file there?
Thanks for

[torvista]

I assume "extra_functions.php" is a typo and you mean "functions_general.php" which is the only file there?

Correct. Thanks for pointing that out.