Possible Bug includes/modules/main_product_image.php

[philip937]

I think possibly I have found a logic flaw with the code in

includes/modules/main_product_image.php

when a site has only small and medium images, the logic is using the small image for the $products_image_large due to the variable $products_image_medium being checked a second time.

original code:

$products_image_extension = substr($products_image, strrpos($products_image, '.'));
$products_image_base = str_replace($products_image_extension, '', $products_image);
$products_image_medium = $products_image_base . IMAGE_SUFFIX_MEDIUM . $products_image_extension;
$products_image_large = $products_image_base . IMAGE_SUFFIX_LARGE . $products_image_extension;

$medium_image_check = $products_image_base . IMAGE_SUFFIX_MEDIUM . $products_image_extension;


// check for a medium image else use small
if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
  $products_image_medium = DIR_WS_IMAGES . $products_image;
} else {
  $products_image_medium = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
}


// check for a large image else use medium else use small
if (!file_exists(DIR_WS_IMAGES . 'large/' . $products_image_large)) {
  if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
    $products_image_large = DIR_WS_IMAGES . $products_image;
  } else {
    $products_image_large = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
  }
} else {
  $products_image_large = DIR_WS_IMAGES . 'large/' . $products_image_large;
} 

as you can see where the second check is taking place, where it is checking for the medium image, its actually looking for:
!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)

and because $products_image_medium has already been defined, it will never actually find the file its looking for:
/images/medium/images/medium/12345_MED.jpg

Perhaps DrByte or someone can clarify incase I have my wires crossed, however I am getting around it by setting an additional variable at the top:

$second_medium_image_check = $products_image_base . IMAGE_SUFFIX_MEDIUM . $products_image_extension; 

and then using this to carry out the second check:

if (!file_exists(DIR_WS_IMAGES . 'large/' . $products_image_large)) {
  if (!file_exists(DIR_WS_IMAGES . 'medium/' . $second_medium_image_check)) {
    $products_image_large = DIR_WS_IMAGES . $products_image;
  } else {
    $products_image_large = DIR_WS_IMAGES . 'medium/' . $second_medium_image_check;
  }
} else {
  $products_image_large = DIR_WS_IMAGES . 'large/' . $products_image_large;
} 

Let me know.

Cheers

Phil

[DrByte]

I suppose if $products_image_medium is already tested and set, then there's no need to look for it again, so simplifying it even further would give you:

// check for a medium image else use small
if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
  $products_image_medium = DIR_WS_IMAGES . $products_image;
} else {
  $products_image_medium = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
}


// check for a large image else use medium else use small
if (!file_exists(DIR_WS_IMAGES . 'large/' . $products_image_large)) {
/**
  if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
    $products_image_large = DIR_WS_IMAGES . $products_image;
  } else {
    $products_image_large = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
  }
*/
  $products_image_large = $products_image_medium;
} else {
  $products_image_large = DIR_WS_IMAGES . 'large/' . $products_image_large;
}

[philip937]

I suppose if $products_image_medium is already tested and set, then there's no need to look for it again, so simplifying it even further would give you:

// check for a medium image else use small
if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
  $products_image_medium = DIR_WS_IMAGES . $products_image;
} else {
  $products_image_medium = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
}


// check for a large image else use medium else use small
if (!file_exists(DIR_WS_IMAGES . 'large/' . $products_image_large)) {
/**
  if (!file_exists(DIR_WS_IMAGES . 'medium/' . $products_image_medium)) {
    $products_image_large = DIR_WS_IMAGES . $products_image;
  } else {
    $products_image_large = DIR_WS_IMAGES . 'medium/' . $products_image_medium;
  }
*/
  $products_image_large = $products_image_medium;
} else {
  $products_image_large = DIR_WS_IMAGES . 'large/' . $products_image_large;
}

Clever clogs ;-)

I also included similar logic in the additional images file as there is only a large image check in there do again when small and medium used when you click the thumbnail by default zen cart only brings up the small, even though there is a medium.