Need some help diagnosing functions_general,php errors

[DrByte]

&& ($key != 'main_page') && ($key != zen_session_name()) && ($key != 'error') && ($key != 'x') && ($key != 'y') ) {
---> and the key is not one of these names.

... and that part is fully redundant because the test for $exclude_array already handles those names.

[philip937]

... and that part is fully redundant because the test for $exclude_array already handles those names.

Do I need to change it then??

[gjh42]

I don't think it hurts anything, just unnecessary. I did wonder why those names needed to be spelled out instead of being put in the exclude array.

[philip937]

While I have some expertise on the thread, I have found one little annoyance with my set up.

As well as the dynamic filter, I have the listing sorter enabled also. I am finding that they both work together but ONLY if you sort first then filter.

if you filter first then sort it looses the filter, sets the sort, then you have to apply the filter again.

Any idea if it would be possible to some how to allow sorting of the filtered results? or would that be a ridiculas amount of custom coding?

[DrByte]

I don't think it hurts anything, just unnecessary. I did wonder why those names needed to be spelled out instead of being put in the exclude array.

It's leftover from the old code in that plugin, which hasn't been upgraded.

[philip937]

oh balls...

ok well I just enabled the sorters that are part of column grid layout and it works.. so its obviously the drop down version I used from another post that is causing it to stop working :o(

i'm using this:
http://www.zen-cart.com/showthread.p...highlight=sort

is the code flawed?