Responsive DIY Template Default for v1.5.x

[marton_1]

My mistake, the file would be tpl_product_info_display.php

If you go to a product page, you will notice the right column sits under the center column

If you right click on page to "view page source" and scroll down you will see the added </div> and where about it is located.

Still unable to duplicate the image issue but haven't given up

Thanks, I have been working with compuzers for 50 years but I still hate them :)

Not sure what you mean by "you will notice the right column sits under the center column" See screenshot of the Desktop version.

Appreciate your help but it is after 1 am here so I will hit the sack.

Cheers

[rbarbour]

Doesn't break on all product pages

Look at this page:
index.php?main_page=product_info&cPath=69_115&products_id=1737

I sent you a PM

Thanks, I have been working with compuzers for 50 years but I still hate them :)

Not sure what you mean by "you will notice the right column sits under the center column" See screenshot of the Desktop version.

Appreciate your help but it is after 1 am here so I will hit the sack.

Cheers

[marton_1]

Did some more testing!

I only see this problem (Image_LRG not large) on my desktop. If I use a tablet or a mobile it is OK.

If I use the ismobile link on my desktop then the image is still not large

[marton_1]

I thought a screenshot or two would be helpful? :)

[marton_1]

Doesn't break on all product pages

Look at this page:
index.php?main_page=product_info&cPath=69_115&products_id=1737

I sent you a PM

I checked the tpl_product_info_display.php but no extra /div; I even gave each div and /div a numbered id to double check.
Got excited when I found an extra /div in the tpl_footer.php (copy/paste error!) but I have yet another /div somewhere.

Does anyone know if there is a list somewhere of the PHP files that are unique to this level; I do not see a layout break at higher levels.

[picaflor-azul]

I checked the tpl_product_info_display.php but no extra /div; I even gave each div and /div a numbered id to double check.
Got excited when I found an extra /div in the tpl_footer.php (copy/paste error!) but I have yet another /div somewhere.

Does anyone know if there is a list somewhere of the PHP files that are unique to this level; I do not see a layout break at higher levels.

I would run the page through the w3c validator to see what lines the errors are happening on.

Thanks,

Anne

[marton_1]

I would run the page through the w3c validator to see what lines the errors are happening on.

Thanks,

Anne

Thanks for the idea

The validator showed up an extra /div - because I have given ids to many of my /divs I can see this one is in TPL_MAIN_PAGE_PHP on line 275.
This seems to be in a good place because here is "* prepares and displays right column sideboxes"

However I checked this PHP and it has 13 divs and 13 /divs so no extra /div. Anyway I tried commenting this /div out but it did not fix my right column problem.
The only change I have made to TPL_MAIN_PAGE_PHP is to add the Google analytics tag at the end
<?php
if (GOOGLE_ANALYTICS_TRACKING_TYPE != "Asynchronous") {
require(DIR_WS_TEMPLATE . 'google_analytics/google_analytics.php');
}
?>

I ran the validator again with this /div commented out and there were no div errors reported.

[marton_1]

I noticed I only have this right column problem on pages that have attributes (like, size, color, etc.) for products that have no attributes the right column is OK.

I checked all the PHP files that have "attribute" in their name but they all seem to the ones I downloaded 2 years ago when I started with Zen cart.

[torvista]

I made quite a few edits for validation while testing this a few weeks ago and since got sidetracked as usual before I could feedback my changes to the author...but after going back and having a look for ten minutes these seem the only changes necessary to cure the errors.

As always, caveat emptor and BACKUP first...I don't have the moment to check these isolated changes I have just extracted from the file comparison.

tpl_footer.php

<!--bof-navigation display --><?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)    if (COLUMN_WIDTH == '0') { ?><div id="navSuppWrapper"><?php }else{ ?><div id="navSuppWrapper" class="<?php echo $fluidisFixed; ?>"><?php } //(BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)--> ?><div id="navSupp">

tpl_header.php

<!--bof-header logo and navigation display--><?phpif (!isset($flag_disable_header) || !$flag_disable_header) {?><?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)    if (COLUMN_WIDTH == '0') {?><div id="headerWrapper"><?php }else{ ?><div id="headerWrapper" class="<?php echo $fluidisFixed; ?>"><?php } // (EOF - 2.1) Responsive DIY Template Default for 1.5.x (65)v ?><!--bof-navigation display-->

tpl_main_page.php

  require($template->get_template_dir('tpl_footer.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_footer.php');?>
<?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)if (COLUMN_WIDTH == '0'){ ?></div><!--end mainWrapper--><?php } //(EOF - 2.1) Responsive DIY Template Default for 1.5.x (65) ?>

and

<!--eof- banner #6 display --><?php //(BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)if (COLUMN_WIDTH == '0'){ ?><!--</div>steve removed--><!--really needed? <br class="clearBoth" />--><!--steve was missing closing slash--><?php }else{ ?><?php //do nothing ?><?php } //(EOF - 2.1) Responsive DIY Template Default for 1.5.x (65) ?></body>

[marton_1]

I made quite a few edits for validation while testing this a few weeks ago and since got sidetracked as usual before I could feedback my changes to the author...but after going back and having a look for ten minutes these seem the only changes necessary to cure the errors.

As always, caveat emptor and BACKUP first...I don't have the moment to check these isolated changes I have just extracted from the file comparison.

tpl_footer.php

<!--bof-navigation display --><?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)    if (COLUMN_WIDTH == '0') { ?><div id="navSuppWrapper"><?php }else{ ?><div id="navSuppWrapper" class="<?php echo $fluidisFixed; ?>"><?php } //(BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)--> ?><div id="navSupp">

tpl_header.php

<!--bof-header logo and navigation display--><?phpif (!isset($flag_disable_header) || !$flag_disable_header) {?><?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)    if (COLUMN_WIDTH == '0') {?><div id="headerWrapper"><?php }else{ ?><div id="headerWrapper" class="<?php echo $fluidisFixed; ?>"><?php } // (EOF - 2.1) Responsive DIY Template Default for 1.5.x (65)v ?><!--bof-navigation display-->

tpl_main_page.php

  require($template->get_template_dir('tpl_footer.php',DIR_WS_TEMPLATE, $current_page_base,'common'). '/tpl_footer.php');?>
<?php // (BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)if (COLUMN_WIDTH == '0'){ ?></div><!--end mainWrapper--><?php } //(EOF - 2.1) Responsive DIY Template Default for 1.5.x (65) ?>

and

<!--eof- banner #6 display --><?php //(BOF - 2.1) Responsive DIY Template Default for 1.5.x (65)if (COLUMN_WIDTH == '0'){ ?><!--</div>steve removed--><!--really needed? <br class="clearBoth" />--><!--steve was missing closing slash--><?php }else{ ?><?php //do nothing ?><?php } //(EOF - 2.1) Responsive DIY Template Default for 1.5.x (65) ?></body>

Tried this but the header change crashed my site (no problem I had a backup).
There are two divs versus one in the current code; does the second div need to be closed somehow, I do not see a /div?