[Done 1.5.2] paypaldp: Module is disabled because SSL is not enabled on your site

[lat9]

Running Zen Cart v1.5.1. PayPal Payments Pro (USA) is enabled as a payment method, with the Debug Mode set to "Log and Email". SSL is enabled on both the store-side and in the admin.

A test order was successfully placed in the store. Whenever the details of that order are viewed in my admin, I receive a log and an email that indicates that "Module is disabled because SSL is not enabled on your site". Examining the code, the message is coming from /includes/modules/payment/paypaldp.php's update_status function:

  /**
   *  Sets payment module status based on zone restrictions etc
   */
  function update_status() {
    global $order, $db;
//    $this->zcLog('update_status', 'Checking whether module should be enabled or not.');
    // if store is not running in SSL, cannot offer credit card module, for PCI reasons
    if (!defined('ENABLE_SSL') || ENABLE_SSL != 'true') {
      $this->enabled = FALSE;
      $this->zcLog('update_status', 'Module disabled because SSL is not enabled on this site.');
    }

The update_status function is being called by the paypaldp constructor, since an $order object exists. Since ENABLE_SSL is defined only on the store-side, that's why the message is being set and the module disabled. Since there is no credit-card information captured during the admin processing, my initial thought is that the code should be modified to perform this check only if operating during the store-side processing.

Will this affect my ability to issue a refund?

[DrByte]

Would you mind testing this change to the code:

    if (IS_ADMIN_FLAG === false) {
      // if store is not running in SSL, cannot offer credit card module, for PCI reasons
      if (!defined('ENABLE_SSL') || ENABLE_SSL != 'true') {
        $this->enabled = FALSE;
        $this->zcLog('update_status', 'Module disabled because SSL is not enabled on this site.');
      }
    }

[lat9]

Would you mind testing this change to the code:

That does the trick, DrByte. Thanks.