php 5.4+ missing payment type in $_SESSION on checkout_process

[texdc]

I don't have the freecharger or moneyorder modules enabled. PayPal EC & IPN are. What I'm getting at is this conditional, which only kicks in when one payment module is enabled.

https://github.com/zencart/zencart/blob/v151/includes/classes/payment.php#L84-L89


I have a custom template and a handful of overrides. It may very well be my mods, but I've already dug through them and none of it sets

$_SESSION['payment'] = NULL; // or an equivalent

As stated originally, I'd really like a point in the right direction, not just "it works on my box."

[DrByte]

As stated originally, I'd really like a point in the right direction, not just "it works on my box."

Sigh. You seem to always hate my replies. Doesn't make me want to help you. I wish we could get past that. The purpose of my reply was NOT to crassly say "it works on my box". It was to engage you in discussion to understand more about exactly how *you* are triggering the scenario because it does appear to be environment-specific.

[DrByte]

Thanks. But, please try again with multiple payment types enabled: AIM, cod, Paypal.

Your earlier post specifically said you were only using AIM.
Then when I replied saying I couldn't recreate the problem (using the limited information about your environment), you said to use more payment modules.
And then when I asked for clarification about *which* PayPal module (again because of limited information in your post), you said you're getting at a conditional related to using only one payment module:

I don't have the freecharger or moneyorder modules enabled. PayPal EC & IPN are. What I'm getting at is this conditional, which only kicks in when one payment module is enabled.

Further, you state "PayPal EC and IPN are [enabled]". But, Zen Cart is specifically coded to *prevent* you from having both EC and Standard enabled at the same time (IPN being commonly referred to as the colloquial name for PayPal Standard).

Either way, if this is indeed related to the code that specifically fires when only one payment module is enabled, I'm having trouble correlating that to the subject of your post: "php 5.4+ missing payment type in $_SESSION on checkout_process". I spent quite a bit of time investigating which PHP 5.4 issues could be causing it, and came up dry. Hence my earlier post asking for more information about your environment.

[texdc]

What we have is a failure to communicate. As I've said, my problem here could very well be my code, but I've combed through it to no avail and was looking for direction.

Now, I've disabled IPN and left EC enabled to see if there's a conflict there (even though it's not used) but the result is the same. So, are you able to debug the ZC code efficiently? If so, I'd really like to know how. Unit tests go a long way to preventing bugs and proving that things work not just on the dev's box. But, I'm not here to complain - though complaint is certainly justified. I just need help fixing a severe problem. If the only places where

$_SESSION['payment'] =

occurs is ZC core (not my mods), then how can I assume that it's my code and not yours?

[DrByte]

Unit tests go a long way to preventing bugs and proving that things work not just on the dev's box.

Agreed entirely. But, someone has to write them. And as you know, procedural code doesn't lend itself well to unit tests.
And that's a discussion we've already had in other forum channels.
That said, thanks for your recent PR's for v1.6.0.

[DrByte]

$_SESSION['payment'] is only reset during processing if $credit_covers is true, and that happens only when the order-total modules determine that any discounts (coupons, gift certificates, etc) equal or exceed the total purchase price, thus determining that there is no payment required. And in that case the store expects that you also have the freecharger module enabled so that it can catch that 0.00 price scenario and complete checkout without requiring payment.

I see from your var_dump that you have $_SESSION['cc_id'] set, which indicates that the system attempted to process a coupon.
And, you stated later that you don't have freecharger enabled.

Does enabling freecharger help?

[texdc]

I've been swamped @ work and added a hack to keep things working until I could dig deeper into this. Here's my solution: `session_write_close()` should be called at the end of every page/script. `zen_session_close()` needs to be fixed:

function zen_session_close() {
  session_write_close();
}