Results 1 to 10 of 35

Hybrid View

  1. #1
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,915
    Plugin Contributions
    13

    Default Re: Github Collaboration

    are you sure you are on the right repository?

    https://github.com/zencart/zencart/issues/new
    author of square Webpay.
    mxWorks now has Apple Pay and Google Pay. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  2. #2
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,835
    Plugin Contributions
    31

    Default Re: Github Collaboration

    are you sure you are on the right repository?
    Yes...I tried again with your link...and have just spotted that if you don't put a title...the Submit does not work...and does not flag the error!

    So, I'll put that down to bad form design, it couldn't be user error!
    Steve
    github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

  3. #3
    Join Date
    Jul 2012
    Posts
    16,817
    Plugin Contributions
    17

    Default Re: Github Collaboration

    Quote Originally Posted by torvista View Post
    Yes...I tried again with your link...and have just spotted that if you don't put a title...the Submit does not work...and does not flag the error!

    So, I'll put that down to bad form design, it couldn't be user error!
    Yeah, there's a similar problem if you edit the code from the github website and after all sorts of clicking this, typing that, if the result of your code is to end up back to where you started, no matter how much content you put into the description box, the button to commit the changes behaves the same way. Sorry for not asking further as I misunderstood the condition(s) that were plainly provided. I thought the issue was that couldn't initiate the area to fill in an issue, not that while filling in the issue information it could not be further submitted. :)
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  4. #4
    Join Date
    Jan 2004
    Posts
    66,446
    Plugin Contributions
    81

    Default Re: Github Collaboration

    FYI the github repo has been renamed from zencart/zencart to zencart/zencart

    Existing checkouts/forks and issues/PRs will continue to work, because github has an internal redirect/alias in place.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #5
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,835
    Plugin Contributions
    31

    Default Re: Github Collaboration

    Regarding working with the local clone fileset, I still feel in the dark about the process and would appreciate some clarification.

    As far as I can see, after creating a local clone, I have to copy this again to make a fileset that can be installed/executed/modified/tested using my local server (since the admin name must be different). There is no way to use this clone directly?

    Once I have finished the modifications, I have to
    a) fetch any changes from origin to local clone to ensure no conflicts.
    b) make a relevant branch in the local clone and copy changes from the installed fileset to the clone to start the push/pull process.

    Seems unwieldy, but I don't find any info that details these nuts and bolts of actual use/testing.
    Steve
    github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

  6. #6
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    10,532
    Plugin Contributions
    127

    Default Re: Github Collaboration

    You can keep the name "admin" in your local testing by adding to your admin/includes/configure.php file this line:

    define('ADMIN_BLOCK_WARNING_OVERRIDE', '1');
    That Software Guy. My Store: Zen Cart Support
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  7. #7
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,835
    Plugin Contributions
    31

    Default Re: Github Collaboration

    You can keep the name "admin" in your local testing..
    Well fancy that!

    So reading between the lines, does that mean the usual way to work is use that override to work directly on the cloned fileset?
    Anything else to add?

    If not, a bit more padding along the lines of your reply and my posts should be added here for future novices:

    http://docs.zen-cart.com/Contributin...ithub_workflow
    Steve
    github.com/torvista: BackupMySQL, Structured Data, Multiple Copy-Move-Delete, Google reCaptcha, Image Checker, Spanish Language Pack and more...

 

 

Similar Threads

  1. Zen Cart GitHub Repository
    By wilt in forum Code Collaboration
    Replies: 9
    Last Post: 30 Sep 2015, 11:27 PM
  2. v154 Putting your contributions on GitHub
    By swguy in forum Contribution-Writing Guidelines
    Replies: 0
    Last Post: 8 Feb 2015, 02:25 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg