Github Collaboration

[mc12345678]

Yes...I tried again with your link...and have just spotted that if you don't put a title...the Submit does not work...and does not flag the error!

So, I'll put that down to bad form design, it couldn't be user error!

Yeah, there's a similar problem if you edit the code from the github website and after all sorts of clicking this, typing that, if the result of your code is to end up back to where you started, no matter how much content you put into the description box, the button to commit the changes behaves the same way. Sorry for not asking further as I misunderstood the condition(s) that were plainly provided. I thought the issue was that couldn't initiate the area to fill in an issue, not that while filling in the issue information it could not be further submitted. :)

[DrByte]

FYI the github repo has been renamed from zencart/zencart to zencart/zencart

Existing checkouts/forks and issues/PRs will continue to work, because github has an internal redirect/alias in place.

[torvista]

Regarding working with the local clone fileset, I still feel in the dark about the process and would appreciate some clarification.

As far as I can see, after creating a local clone, I have to copy this again to make a fileset that can be installed/executed/modified/tested using my local server (since the admin name must be different). There is no way to use this clone directly?

Once I have finished the modifications, I have to
a) fetch any changes from origin to local clone to ensure no conflicts.
b) make a relevant branch in the local clone and copy changes from the installed fileset to the clone to start the push/pull process.

Seems unwieldy, but I don't find any info that details these nuts and bolts of actual use/testing.

[swguy]

You can keep the name "admin" in your local testing by adding to your admin/includes/configure.php file this line:

define('ADMIN_BLOCK_WARNING_OVERRIDE', '1');

[torvista]

You can keep the name "admin" in your local testing..

Well fancy that!

So reading between the lines, does that mean the usual way to work is use that override to work directly on the cloned fileset?
Anything else to add?

If not, a bit more padding along the lines of your reply and my posts should be added here for future novices:

http://docs.zen-cart.com/Contributin...ithub_workflow

[swguy]

- You should do your changes on a branch and submit them as a PR.
- Update frequently.
- If you are working on the develop branch (the old 1.6.0), you will need to recreate your database frequently; database changes are made that you'll need to have for things to keep working. Alternatively, you can keep a 1.5.5 database around and run the upgrade process, which usually works (if it doesn't open an Issue).
- Keep your PRs scoped to *just* the issue you are fixing; don't submit a PR with 10 fixes in it.
- Have fun! :)

[torvista]

what about having to rename/hide the zc_install directory?