Call to undefined function zen_datetime_short() after installing Print Invoice Popup

[DML73]

After installing the Print Invoice Popup mod:

http://www.zen-cart.com/downloads.php?do=file&id=1089

Im getting the following error in my logs folder:

[19-Jul-2014 06:55:28 America/Chicago] PHP Fatal error: Call to undefined function zen_datetime_short() in /home/mywebsite/www/includes/modules/print_invoice.php on line 421

I know that module is made for zencart version 1.3.0 but it seems to work fine with 1.5.1 except that Im getting the above error in my logs folder.

Anybody knows how to correct this error?

Line 421 in print_invoice.php looks like this:
<td class="smallText" align="left" valign="top">' . zen_datetime_short($orders_history->fields['date_added']) . '</td>' . "\n";

I guess the problem is the "zen_datetime_short" definition, but what is the correct definition??

[DrByte]

Since in original ZC code that function is defined in /admin/includes/functions/general.php, it can only be used on the admin side.
So, perhaps the plugin has a functions file where it also defines it on the storefront side by putting a file with just that function somewhere under the /includes/functions/extra_functions folder? ... in which case it seems as though you've not actually uploaded all the files that probably came with the plugin?

[DML73]

Thanks. I just re-checked that I did upload all files.
When I search for "zen_datetime_short" in admin->Tools->Developers Tool Kit then I can see that this string only exists in the following files:

/includes/classes/super_order.php
/includes/modules/payment/paypal/paypal_admin_notification.php
/includes/modules/print_invoice.php

I also see no functions file in the plugin folders. So apparently there is no file defining this function.

Is there a way I can add such a file defining this function relatively easy? What would the code be? (unfortunately Im not a programmer )

[gjh42]

You apparently didn't search in admin files. I found this in my v1.5.1 files:

/my_admin/includes/functions/general.php
Line #169 : function zen_datetime_short($raw_datetime) {

If you look at that file, you should be able to copy that function into a new file (you can name it like datetime_functions.php or whatever) and save the file in your main /includes/functions/extra_functions/ folder.

[DML73]

Great thanks, its working! I put:

function zen_datetime_short($raw_datetime) {
    if ( ($raw_datetime == '0001-01-01 00:00:00') || ($raw_datetime == '') ) return false;

    $year = (int)substr($raw_datetime, 0, 4);
    $month = (int)substr($raw_datetime, 5, 2);
    $day = (int)substr($raw_datetime, 8, 2);
    $hour = (int)substr($raw_datetime, 11, 2);
    $minute = (int)substr($raw_datetime, 14, 2);
    $second = (int)substr($raw_datetime, 17, 2);

    return strftime(DATE_TIME_FORMAT, mktime($hour, $minute, $second, $month, $day, $year));
  }

into a new file called datetime_functions.php and put it in /includes/functions/extra_functions as you suggested. Now I no longer get the error in my logs folder.

[lat9]

Just in case that function "comes over to the store-side" in a future release of Zen Cart, you might want to make a slight update:

if (!function_exists('zen_datetime_short')) {
  function zen_datetime_short($raw_datetime) {
    if ( ($raw_datetime == '0001-01-01 00:00:00') || ($raw_datetime == '') ) return false;

    $year = (int)substr($raw_datetime, 0, 4);
    $month = (int)substr($raw_datetime, 5, 2);
    $day = (int)substr($raw_datetime, 8, 2);
    $hour = (int)substr($raw_datetime, 11, 2);
    $minute = (int)substr($raw_datetime, 14, 2);
    $second = (int)substr($raw_datetime, 17, 2);

    return strftime(DATE_TIME_FORMAT, mktime($hour, $minute, $second, $month, $day, $year));
  }
}

[DML73]

Thanks, I made the update.