Creating default object from empty value in modules/payment/authorizenet_aim.php

[bumba000]

I was able to fix this issue by changing line 439 from

    $aimdata->fields = array();

to

if (!isset($aimdata)){ 
     $aimdata = new stdClass();
}
$aimdata->fields = array();

[mc12345678]

I was able to fix this issue by changing line 439 from

    $aimdata->fields = array();

to

if (!isset($aimdata)){ 
     $aimdata = new stdClass();
}
$aimdata->fields = array();

The if test appears unnecessary when looking at the provided code:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

Because there is nothing between the function declaration and the first use of $aimdata-> $aimdata will never be set and therefore the code within the if statement will always be executed. I.e. there is no parameter passed to the function assigned to $aimdata, there's no global $aimdata, and no previous assignment.

Now if that code section is otherwise modified to attempt to pass/operate differently, then it would be helpful to know how it has been edited.

The solution referenced earlier in the conversation was to do something similar but as described without the if statement.

[lat9]

The if test appears unnecessary when looking at the provided code:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

Because there is nothing between the function declaration and the first use of $aimdata-> $aimdata will never be set and therefore the code within the if statement will always be executed. I.e. there is no parameter passed to the function assigned to $aimdata, there's no global $aimdata, and no previous assignment.

Now if that code section is otherwise modified to attempt to pass/operate differently, then it would be helpful to know how it has been edited.

The solution referenced earlier in the conversation was to do something similar but as described without the if statement.

Actually, the following statement is the something that's between the function definition and the first usage.

 $aimdata->fields = array();

Since it's $aimdata->fields that's being assigned that empty array, that's where the issue arises because $aimdata is not an object. I do agree that the change could be simplified as follows to "prepare" for the use of that required handling:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    $aimdata = new stdClass();
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

[mc12345678]

Actually, the following statement is the something that's between the function definition and the first usage.

 $aimdata->fields = array();

Since it's $aimdata->fields that's being assigned that empty array, that's where the issue arises because $aimdata is not an object. I do agree that the change could be simplified as follows to "prepare" for the use of that required handling:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    $aimdata = new stdClass();
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

We've said the same thing.

Note: an if statement/conditional test was not used/needed before the first $aimdata-> and that the assignment within the previous if statement was still used/needed.

Although no question was asked nor a statement directly made of not understanding the textual description, the following expanded and broken down information is provided. In my opinion likely to still be misunderstood, but please ask away about whatever is confusing or not understood or where I have possibly used incorrect terminology.

Function declaration:

function admin_notification($zf_order_id)

Parameter(s) (none are $aimdata):

$zf_order_id

Global(s) (none include $aimdata):

    global $db;

First usage of $aimdata->:

 $aimdata->fields = array();

The code expected that contains the unnecessary if condition:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    if (!isset($aimdata)) {
      $aimdata = new stdClass();
    }
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

Considered unnecessary because the if statement evaluates like this all of the time:

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    if (true) {
      $aimdata = new stdClass();
    }
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

And therefore could be written without the if statement as described previously in text, as provided above (ie lat9's post) and as DrByte indicated in the rework of ZC to elimate the error/improve the code.

function admin_notification($zf_order_id) {
    global $db;
    $output = '';
    $aimdata = new stdClass();
    $aimdata->fields = array();
    require(DIR_FS_CATALOG . DIR_WS_MODULES . 'payment/authorizenet/authorizenet_admin_notification.php');
    return $output;
  }

Again though as discussed if there have been other edits to the code above the first use of $aimdata->, then the if statement may be necessary. But there has not been any indication of such. If there has been such an edit, it would be beneficial to know about so that one can evaluate whether the if statement is in fact necessary or not.

[lat9]

We might have; I just said it a tad more succinctly.

[DrByte]

It can be even simpler than that, since the $aimdata variable isn't actually used in the admin_notification file. Doh. Leftover code from back when we hoped AIM would provide it.

v1.5.6 will have it removed: https://github.com/zencart/zencart/pull/1465/files -- you can make the same changes today, in any version of Zen Cart.