Clarification for ADMIN Classes referenced in: init_currencies.php

[Mega Moonshine]

Using ZC v1.5.3 and adding a plugin/mod (Edit Orders v4.1.4)

While comparing the plugin/mod version for the file admin/includes/init_includes/init_currencies.php with the default version in v1.5.3, I noticed the following:

ZC v1.5.3 original/untouched has the line:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'class.currencies.php');

Yet the (original v1.5.3) folder/directory under admin/includes/classes has only the following file(name):

currencies.php

and not one named: class.currencies.php

That being the case, is there a problem here?

What does it need to be, to be accurate and not throw an error or warning?

That is:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'class.currencies.php');

or this:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'currencies.php');

Thanks in advance for clarifying...

[mc12345678]

Using ZC v1.5.3 and adding a plugin/mod (Edit Orders v4.1.4)

While comparing the plugin/mod version for the file admin/includes/init_includes/init_currencies.php with the default version in v1.5.3, I noticed the following:

ZC v1.5.3 original/untouched has the line:



Yet the (original v1.5.3) folder/directory under admin/includes/classes has only the following file(name):

currencies.php

and not one named: class.currencies.php

That being the case, is there a problem here?

What does it need to be, to be accurate and not throw an error or warning?

That is:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'class.currencies.php');

or this:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'currencies.php');

Thanks in advance for clarifying...

Does edit orders add a class.currencies.php file into the associated admin directory? The default ZC 1.5.3 as identified above and not confirmed is loading the class.currencies.php from the store not from the admin. As for edit orders, if it adds it's own then, it will likely call it's own; however, might want to check the plugins thread to see if this is addressed. Does that clarify nything for you?

[lhungil]

Zen Cart 1.5.x has a typo in "admin/includes/init_includes/init_currencies.php". This file is not currently used by any other core Zen Cart files (and therefore does not cause any severe issues to a stock installation of Zen Cart 1.5.x). The file appears to be scheduled for removal in Zen Cart 1.6+. https://github.com/zencart/zencart/issues/112

Edit Orders 4.1.4 DOES use this file. The distribution zip for Edit Orders 4.1.4 includes a corrected version of this file (inside the modified_files folder). Basically just fixing the name of the file required for using the currencies class.

[Mega Moonshine]

@lhungil - Thanks! Sorry for delay, had a great Labor Day weekend.

To recap, the answer is (for the Edit Orders v4.1.4 mod) that it provides the corrected line:

require(DIR_FS_CATALOG . DIR_WS_CLASSES . 'currencies.php');

As the logs folder never had any error files for this, it is what I thought and had used, just wanted to be sure by asking the experts...