Upgrade to PHP 5.4

[jeking]

A client's host will be upgrading to PHP 5.4 next week. We will be upgrading to Zen Cart 1.5.3, but not before then. The only reference I can find for the needed patches for 1.5.1 to work with PHP 5.4 is here:
https://github.com/zencart/zencart/c...2cb78fc86946c9

Is that an accurate and complete list?

[mc12345678]

No, it is not complete. There is also a change I thinkit is in includes/classes/sessions.php where there is a check against the constant SID. There is an if statement followed by an assignment both with SID in it. The SID constant must be cast as a constant like: constant('SID') in both lines.

This change could be made in advance of the php 5.4 upgrade.